Skip to content

chore(sdk): bump v2.0.0-beta.16 #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreJeanjacquot merged 65 commits into from
Jun 16, 2025

chore(sdk): bump sdk v2.0.0-beta.16

00a9d82
Select commit
Loading
Failed to load commit list.
Merged

chore(sdk): bump v2.0.0-beta.16 #454

chore(sdk): bump sdk v2.0.0-beta.16
00a9d82
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed Jun 16, 2025 in 18s

15 new alerts including 1 high severity security vulnerability

New alerts in code changed by this pull request

Security Alerts:

  • 1 high
  • 2 medium
  • 2 low

Other Alerts:

  • 10 warnings

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 201 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

DataProtectorSharing._update(address,uint256,address) uses timestamp for comparisons
Dangerous comparisons:
- _collectionDetails.lastSubscriptionExpiration > block.timestamp

Check warning on line 205 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.getProtectedDataRenter(address,address)._protectedData is not in mixedCase

Check warning on line 206 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.getProtectedDataRenter(address,address)._renterAddress is not in mixedCase

Check warning on line 221 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.receiveApproval(address,uint256,address,bytes)._sender is not in mixedCase

Check warning on line 224 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.receiveApproval(address,uint256,address,bytes)._extraData is not in mixedCase

Check warning on line 384 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setSubscriptionParams(uint256,ISubscription.SubscriptionParams)._collectionTokenId is not in mixedCase

Check warning on line 385 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setSubscriptionParams(uint256,ISubscription.SubscriptionParams)._subscriptionParams is not in mixedCase

Check warning on line 438 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setProtectedDataToRenting(address,IRental.RentingParams)._protectedData is not in mixedCase

Check warning on line 439 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Parameter DataProtectorSharing.setProtectedDataToRenting(address,IRental.RentingParams)._rentingParams is not in mixedCase

Check failure on line 495 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Check warning on line 495 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Deletion on mapping containing a structure Medium

DataProtectorSharing._buyProtectedData(address,address,address,uint72) deletes IDataProtectorSharing.ProtectedDataDetails which contains a mapping:
-delete protectedDataDetails[_protectedData]

Check warning on line 495 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Medium

Reentrancy in DataProtectorSharing._buyProtectedData(address,address,address,uint72):
External calls:
- PROTECTED_DATA_REGISTRY.safeTransferFrom(address(this),_to,uint256(uint160(_protectedData)))
- POCO_DELEGATE.transferFrom(spender,ownerOf(_protectedDataDetails.collection),_protectedDataDetails.sellingParams.price)
State variables written after the call(s):
- delete protectedDataDetails[_protectedData]
DataProtectorSharing.protectedDataDetails can be used in cross function reentrancies:
- DataProtectorSharing._buyProtectedData(address,address,address,uint72)
- DataProtectorSharing._checkAndGetConsumeProtectedDataMode(address,IexecLibOrders_v5.WorkerpoolOrder)
- DataProtectorSharing._checkProtectedDataForSale(address)
- DataProtectorSharing._checkProtectedDataNotForSale(address)
- DataProtectorSharing._checkProtectedDataNotRented(address)
- DataProtectorSharing._rentProtectedData(address,address,IRental.RentingParams)
- DataProtectorSharing.addProtectedDataToCollection(uint256,address,IAddOnlyAppWhitelist)
- DataProtectorSharing.consumeProtectedData(address,IexecLibOrders_v5.WorkerpoolOrder,address)
- DataProtectorSharing.getProtectedDataRenter(address,address)
- DataProtectorSharing.protectedDataDetails
- [DataProtectorSharing.removeProtectedDataForSale(

Check notice on line 495 in packages/sharing-smart-contract/contracts/DataProtectorSharing.sol

See this annotation in the file changed.

Check warning on line 36 in packages/sharing-smart-contract/contracts/ManageOrders.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable ManageOrders.POCO_DELEGATE is not in mixedCase

Check warning on line 26 in packages/sharing-smart-contract/contracts/registry/AddOnlyAppWhitelist.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Variable AddOnlyAppWhitelist.APP_WHITELIST_REGISTRY is not in mixedCase