-
Notifications
You must be signed in to change notification settings - Fork 46
feat: allow searching apporders and datasetorders by asset owner #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
6ece1e4 to
937517e
Compare
937517e to
c71dced
Compare
…setOrderbook(datasetAddress, options)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the orderbook API to allow searching by asset owner while maintaining backward compatibility. The API changes from passing the asset address as the first parameter to accepting an options object that can contain either the asset address or the owner address.
- Added support for searching app/dataset orders by owner address (appOwner/datasetOwner parameters)
- Refactored function signatures to accept options object as first parameter instead of asset address
- Maintained backward compatibility with deprecation warnings for the old API
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/market/orderbook.js | Core implementation refactoring to support new options object parameter and owner-based searching |
| src/lib/IExecOrderbookModule.js | Updated method signatures to match new parameter structure |
| src/cli/cmd/iexec-orderbook.js | Updated CLI commands to use new options object format |
| src/cli/cmd/iexec-app.js | Updated app CLI commands to use new options object format |
| test/lib/e2e/IExecOrderbookModule.test.js | Updated tests to use new API and added tests for owner-based searching |
| docs/classes/IExecOrderbookModule.md | Updated documentation to reflect new API signature and deprecation notices |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Le-Caignec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments for consistency between function signatures.


overloaded fetchAppOrderbook and fetchDatasetOrderbook methods: