Skip to content

feat: allow searching apporders and datasetorders by asset owner #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreJeanjacquot merged 3 commits into from
Oct 2, 2025
Merged

feat: allow searching apporders and datasetorders by asset owner #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c71dced
feat: allow searching apporders and datasetorders by asset owner
PierreJeanjacquot Sep 29, 2025
bc2e862
chore: deprecate fetchAppOrderbook(appAddress, options) and fetchData…
PierreJeanjacquot Oct 2, 2025
ef2337f
fix: missing label
PierreJeanjacquot Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/classes/IExecOrderbookModule.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ current IExecConfig

### fetchAppOrderbook

▸ **fetchAppOrderbook**(`appAddress`, `options?`): `Promise`<[`PaginableOrders`](../interfaces/internal_.PaginableOrders.md)<[`PublishedApporder`](../interfaces/internal_.PublishedApporder.md)\>\>
▸ **fetchAppOrderbook**(`appAddressOrOptions`, `options?`): `Promise`<[`PaginableOrders`](../interfaces/internal_.PaginableOrders.md)<[`PublishedApporder`](../interfaces/internal_.PublishedApporder.md)\>\>

find the cheapest orders for the specified app.

Expand All @@ -88,8 +88,8 @@ console.log('total orders:', count);

| Name | Type | Description |
| :------ | :------ | :------ |
| `appAddress` | `string` | - |
| `options?` | `Object` | - |
| `appAddressOrOptions` | `string` \| { `app?`: `string` ; `appOwner?`: `string` ; `dataset?`: `string` ; `isDatasetStrict?`: `boolean` ; `isRequesterStrict?`: `boolean` ; `isWorkerpoolStrict?`: `boolean` ; `maxTag?`: [`Tag`](../modules.md#tag) \| `string`[] ; `minTag?`: [`Tag`](../modules.md#tag) \| `string`[] ; `minVolume?`: [`BNish`](../modules.md#bnish) ; `page?`: `number` ; `pageSize?`: `number` ; `requester?`: `string` ; `workerpool?`: `string` } | - |
| `options?` | `Object` | **`Deprecated`** use first parameter instead migration: replace `fetchAppOrderbook(appAddress, options)` by `fetchAppOrderbook({ app: appAddress, ...options })` |
| `options.dataset?` | `string` | include orders restricted to specified dataset (use `'any'` to include any dataset) |
| `options.isDatasetStrict?` | `boolean` | filters out orders allowing “any” dataset (default: `false`) |
| `options.isRequesterStrict?` | `boolean` | filters out orders allowing “any” requester (default: `false`) |
Expand Down Expand Up @@ -135,7 +135,7 @@ ___

### fetchDatasetOrderbook

▸ **fetchDatasetOrderbook**(`datasetAddress`, `options?`): `Promise`<[`PaginableOrders`](../interfaces/internal_.PaginableOrders.md)<[`PublishedDatasetorder`](../interfaces/internal_.PublishedDatasetorder.md)\>\>
▸ **fetchDatasetOrderbook**(`datasetAddressOrOptions`, `options?`): `Promise`<[`PaginableOrders`](../interfaces/internal_.PaginableOrders.md)<[`PublishedDatasetorder`](../interfaces/internal_.PublishedDatasetorder.md)\>\>

find the cheapest orders for the specified dataset.

Expand All @@ -152,8 +152,8 @@ console.log('total orders:', count);

| Name | Type | Description |
| :------ | :------ | :------ |
| `datasetAddress` | `string` | - |
| `options?` | `Object` | - |
| `datasetAddressOrOptions` | `string` \| { `app?`: `string` ; `dataset?`: `string` ; `datasetOwner?`: `string` ; `isAppStrict?`: `boolean` ; `isRequesterStrict?`: `boolean` ; `isWorkerpoolStrict?`: `boolean` ; `maxTag?`: [`Tag`](../modules.md#tag) \| `string`[] ; `minTag?`: [`Tag`](../modules.md#tag) \| `string`[] ; `minVolume?`: [`BNish`](../modules.md#bnish) ; `page?`: `number` ; `pageSize?`: `number` ; `requester?`: `string` ; `workerpool?`: `string` } | - |
| `options?` | `Object` | **`Deprecated`** use first parameter instead migration: replace `fetchDatasetOrderbook(datasetAddress, options)` by `fetchDatasetOrderbook({ dataset: datasetAddress, ...options })` |
| `options.app?` | `string` | include orders restricted to specified app (use `'any'` to include any app) |
| `options.isAppStrict?` | `boolean` | filters out orders allowing “any” app (default: `false`) |
| `options.isRequesterStrict?` | `boolean` | filters out orders allowing “any” requester (default: `false`) |
Expand Down
4 changes: 2 additions & 2 deletions src/cli/cmd/iexec-app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@
.option(...option.useVoucher())
.option(...option.voucherAddress())
.description(desc.appRun())
.action(async (appAddress, opts) => {

Check warning on line 591 in src/cli/cmd/iexec-app.js

View workflow job for this annotation

GitHub Actions / check-code 

Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed

Check warning on line 591 in src/cli/cmd/iexec-app.js

View workflow job for this annotation

GitHub Actions / npm-dry-run / npm-publish / build 

Refactor this function to reduce its Cognitive Complexity from 40 to the 15 allowed
await checkUpdate(opts);
const spinner = Spinner(opts);
try {
Expand Down Expand Up @@ -775,8 +775,8 @@
const { orders } = await fetchAppOrderbook(
chain.contracts,
getPropertyFormChain(chain, 'iexecGateway'),
app,
{
app,
requester,
...(useDataset && { dataset }),
...(runOnWorkerpool && { workerpool }),
Expand Down Expand Up @@ -819,8 +819,8 @@
const { orders } = await fetchDatasetOrderbook(
chain.contracts,
getPropertyFormChain(chain, 'iexecGateway'),
dataset,
{
dataset,
app,
requester,
...(runOnWorkerpool && { workerpool }),
Expand Down Expand Up @@ -1185,7 +1185,7 @@
.option(...orderOption.params())
.option(...option.skipPreflightCheck())
.description(desc.requestRun())
.action(async (app, opts) => {

Check warning on line 1188 in src/cli/cmd/iexec-app.js

View workflow job for this annotation

GitHub Actions / check-code 

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed

Check warning on line 1188 in src/cli/cmd/iexec-app.js

View workflow job for this annotation

GitHub Actions / npm-dry-run / npm-publish / build 

Refactor this function to reduce its Cognitive Complexity from 26 to the 15 allowed
await checkUpdate(opts);
const spinner = Spinner(opts);
try {
Expand Down
4 changes: 2 additions & 2 deletions src/cli/cmd/iexec-orderbook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ orderbookApp
const request = fetchAppOrderbook(
chain.contracts,
getPropertyFormChain(chain, 'iexecGateway'),
app,
{
app,
dataset,
workerpool,
requester,
Expand Down Expand Up @@ -180,8 +180,8 @@ orderbookDataset
const request = fetchDatasetOrderbook(
chain.contracts,
getPropertyFormChain(chain, 'iexecGateway'),
dataset,
{
dataset,
app,
workerpool,
requester,
Expand Down
Loading
Loading