Skip to content

Conversation

@Le-Caignec
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 13, 2025

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
Dockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>`

@Le-Caignec Le-Caignec self-assigned this Oct 13, 2025
@Le-Caignec Le-Caignec requested a review from Copilot October 13, 2025 11:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR moves Arbitrum Sepolia (chain ID 421614) from experimental to stable network status by setting isExperimental: false in the network configuration. This change eliminates the need for the allowExperimentalNetworks flag when using this network.

  • Updated network configuration to mark Arbitrum Sepolia as a stable (non-experimental) network
  • Removed all tests related to the allowExperimentalNetworks flag for Arbitrum Sepolia
  • Applied code formatting improvements to template literals in CLI helper

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/common/utils/config.js Changed isExperimental flag from true to false for Arbitrum Sepolia network
test/lib/unit/config.test.js Removed test verifying experimental network accessibility with the flag
test/lib/e2e/utils.test.js Removed test for creating signers on experimental networks
test/lib/e2e/IExecConfig.test.js Removed two test suites validating experimental network behavior with chain name and chain ID
src/cli/utils/cli-helper.js Simplified template literal formatting for task status messages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Le-Caignec Le-Caignec changed the title feat: move arbitrum sepolia to non experiemental network feat: Migrate arbitrum-sepolia-testnet from experimental to non-experimental network Oct 13, 2025
@PierreJeanjacquot PierreJeanjacquot self-requested a review October 13, 2025 12:03
@PierreJeanjacquot PierreJeanjacquot force-pushed the feat/move-arbitrum-sepolia-to-non-experiemental-network branch from 639d2e1 to bf89c42 Compare October 13, 2025 12:04
Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Le-Caignec could you just skip tests related to experimental networks instead of removing them?
The feature code is still present and could be useful next time a network is added it would be nice to have the related tests ready.

@Le-Caignec
Copy link
Contributor Author

@PierreJeanjacquot yeah no problem. I can do that instead

@Le-Caignec Le-Caignec force-pushed the feat/move-arbitrum-sepolia-to-non-experiemental-network branch from 470f019 to 639d2e1 Compare October 13, 2025 12:42
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
43.0% Coverage on New Code (required ≥ 80%)
12.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Member

@PierreJeanjacquot PierreJeanjacquot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreJeanjacquot PierreJeanjacquot merged commit ab23604 into master Oct 14, 2025
9 of 10 checks passed
@PierreJeanjacquot PierreJeanjacquot deleted the feat/move-arbitrum-sepolia-to-non-experiemental-network branch October 14, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants