-
Notifications
You must be signed in to change notification settings - Fork 46
feat: Migrate arbitrum-sepolia-testnet from experimental to non-experimental network
#471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate arbitrum-sepolia-testnet from experimental to non-experimental network
#471
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsDockerfile:17 DL3016 warning: Pin versions in npm. Instead of `npm install <package>` use `npm install <package>@<version>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves Arbitrum Sepolia (chain ID 421614) from experimental to stable network status by setting isExperimental: false in the network configuration. This change eliminates the need for the allowExperimentalNetworks flag when using this network.
- Updated network configuration to mark Arbitrum Sepolia as a stable (non-experimental) network
- Removed all tests related to the
allowExperimentalNetworksflag for Arbitrum Sepolia - Applied code formatting improvements to template literals in CLI helper
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/utils/config.js | Changed isExperimental flag from true to false for Arbitrum Sepolia network |
| test/lib/unit/config.test.js | Removed test verifying experimental network accessibility with the flag |
| test/lib/e2e/utils.test.js | Removed test for creating signers on experimental networks |
| test/lib/e2e/IExecConfig.test.js | Removed two test suites validating experimental network behavior with chain name and chain ID |
| src/cli/utils/cli-helper.js | Simplified template literal formatting for task status messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
arbitrum-sepolia-testnet from experimental to non-experimental network
639d2e1 to
bf89c42
Compare
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Le-Caignec could you just skip tests related to experimental networks instead of removing them?
The feature code is still present and could be useful next time a network is added it would be nice to have the related tests ready.
|
@PierreJeanjacquot yeah no problem. I can do that instead |
470f019 to
639d2e1
Compare
|
PierreJeanjacquot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM


No description provided.