Skip to content

feat: Migrate arbitrum-sepolia-testnet from experimental to non-experimental network #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PierreJeanjacquot merged 8 commits into from
Oct 14, 2025
Merged

feat: Migrate arbitrum-sepolia-testnet from experimental to non-experimental network #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
880f12f
test: remove tests for experimental networks in utils and config
Le-Caignec Oct 13, 2025
f57e271
fix: simplify string interpolation in renderTasksStatus function
Le-Caignec Oct 13, 2025
7cc7e5d
refactor: improve readability by simplifying function call formatting…
Le-Caignec Oct 13, 2025
639d2e1
test: remove tests for experimental networks in IExecConfig
Le-Caignec Oct 13, 2025
700c026
test: add tests for experimental networks in utils and config
Le-Caignec Oct 13, 2025
67eb241
test: add support for experimental networks in IExecConfig
Le-Caignec Oct 13, 2025
6a6b8d5
Merge branch 'master' into feat/move-arbitrum-sepolia-to-non-experiem…
Le-Caignec Oct 13, 2025
8bdabb0
test: skip experimental networks tests in IExecConfig
Le-Caignec Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/cli/utils/cli-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1057,9 +1057,7 @@ export const renderTasksStatus = (
: '\n';
const completedMsg =
completedTasksArray.length > 0
? `${completedTasksArray.length}/${tasksArray.length} tasks completed${
completedDetails
}`
? `${completedTasksArray.length}/${tasksArray.length} tasks completed${completedDetails}`
: '';

const failedDetails = detailed
Expand All @@ -1071,9 +1069,7 @@ export const renderTasksStatus = (
: '\n';
const failedMsg =
timedoutTasksArray.length > 0
? `${timedoutTasksArray.length}/${tasksArray.length} tasks failed${
failedDetails
}`
? `${timedoutTasksArray.length}/${tasksArray.length} tasks failed${failedDetails}`
: '';
const statusMsg =
runningTasksArray.length > 0
Expand Down
2 changes: 1 addition & 1 deletion src/common/utils/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ const networkConfigs = [
voucherSubgraph: undefined, // no voucher
bridge: {}, // no bridge
shouldRegisterNetwork: false,
isExperimental: true,
isExperimental: false,
},
{
id: 42161,
Expand Down
8 changes: 4 additions & 4 deletions test/lib/e2e/IExecConfig.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ describe('[IExecConfig]', () => {
);
expect(createConfig).toThrow(errors.ConfigurationError);
});
describe('allowExperimentalNetworks', () => {
describe.skip('allowExperimentalNetworks', () => {
test('throw with experimental chains when allowExperimentalNetworks is not enabled', () => {
const createConfig = () =>
new IExecConfig({ ethProvider: 'arbitrum-sepolia-testnet' });
Expand Down Expand Up @@ -242,7 +242,7 @@ describe('[IExecConfig]', () => {
);
expect(createConfig).toThrow(errors.ConfigurationError);
});
describe('allowExperimentalNetworks', () => {
describe.skip('allowExperimentalNetworks', () => {
test('throw with experimental chains when allowExperimentalNetworks is not enabled', () => {
const createConfig = () => new IExecConfig({ ethProvider: 421614 });
expect(createConfig).toThrow(
Expand Down Expand Up @@ -421,7 +421,7 @@ describe('[IExecConfig]', () => {
network.getPlugin('org.ethers.plugins.network.Ens').address,
).toBe('0x5f5B93fca68c9C79318d1F3868A354EE67D8c006');
});
describe('allowExperimentalNetworks', () => {
describe.skip('allowExperimentalNetworks', () => {
const experimentalNetworkRpcUrl = getChainDefaults(421614, {
allowExperimentalNetworks: true,
}).host;
Expand Down Expand Up @@ -526,7 +526,7 @@ describe('[IExecConfig]', () => {
network.getPlugin('org.ethers.plugins.network.Ens').address,
).toBe(iexecTestChain.defaults.ensRegistryAddress);
});
describe('allowExperimentalNetworks', () => {
describe.skip('allowExperimentalNetworks', () => {
const experimentalNetworkRpcUrl = getChainDefaults(421614, {
allowExperimentalNetworks: true,
}).host;
Expand Down
2 changes: 1 addition & 1 deletion test/lib/e2e/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,7 +601,7 @@ describe('utils', () => {
).wallet.checkBalances(NULL_ADDRESS),
).resolves.toBeDefined();
});
test('allowExperimentalNetworks option allow creating signer connected to an experimental network', async () => {
test.skip('allowExperimentalNetworks option allow creating signer connected to an experimental network', async () => {
expect(() =>
utils.getSignerFromPrivateKey(
'arbitrum-sepolia-testnet',
Expand Down
2 changes: 1 addition & 1 deletion test/lib/unit/config.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('getChainDefaults', () => {
test('unknown id returns empty object', () => {
expect(getChainDefaults(0)).toEqual({});
});
test('experimental networks are accessible with `allowExperimentalNetworks:true` hidden by default', () => {
test.skip('experimental networks are accessible with `allowExperimentalNetworks:true` hidden by default', () => {
expect(getChainDefaults(421614)).toEqual({});
expect(
getChainDefaults(421614, { allowExperimentalNetworks: true }).host,
Expand Down
Loading