Skip to content

Conversation

@radiolinkW
Copy link
Contributor

@radiolinkW radiolinkW commented Jan 8, 2026

PR Type

Enhancement


Description

  • Add M25P16 flash memory support alongside existing W25N01G

  • Configure M25P16 on SPI3 bus with chip select pin PD2

  • Enable M25P16 flash driver in blackbox configuration


Diagram Walkthrough

flowchart LR
  A["RADIOLINKF722 Target"] -- "SPI3 Configuration" --> B["M25P16 Flash"]
  A -- "SPI3 Configuration" --> C["W25N01G Flash"]
  B -- "CS Pin PD2" --> D["Flash Storage"]
  C -- "CS Pin PD2" --> D
Loading

File Walkthrough

Relevant files
Enhancement
target.h
Add M25P16 flash memory configuration                                       

src/main/target/RADIOLINKF722/target.h

  • Added M25P16 flash memory configuration with SPI3 bus and PD2 chip
    select pin
  • Enabled USE_FLASH_M25P16 driver flag for blackbox logging support
  • Maintains existing W25N01G flash configuration on same SPI3 bus
+4/-0     

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

PR Compliance Guide 🔍

All compliance sections have been disabled in the configurations.

Comment on lines 113 to 122
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PD2

#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2

#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16
#define USE_FLASH_W25N01G
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Resolve a critical SPI bus conflict by removing the definitions for the older W25N01G flash chip, as it shares the same bus and chip-select pin as the newly added M25P16. [possible issue, importance: 10]

Suggested change
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PD2
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2
#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16
#define USE_FLASH_W25N01G
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2
#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants