Skip to content

RADIOLINKF722: add w25q128 flash #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sensei-hacker merged 1 commit into from
Jan 13, 2026
+4 −0
Merged

RADIOLINKF722: add w25q128 flash #11232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/target/RADIOLINKF722/target.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,12 @@
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PD2

#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2

#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16
#define USE_FLASH_W25N01G
Comment on lines 113 to 122
Copy link
Contributor

@qodo-code-review qodo-code-review bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Resolve a critical SPI bus conflict by removing the definitions for the older W25N01G flash chip, as it shares the same bus and chip-select pin as the newly added M25P16. [possible issue, importance: 10]

Suggested change
#define W25N01G_SPI_BUS BUS_SPI3
#define W25N01G_CS_PIN PD2
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2
#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16
#define USE_FLASH_W25N01G
#define M25P16_SPI_BUS BUS_SPI3
#define M25P16_CS_PIN PD2
#define USE_BLACKBOX
#define USE_FLASHFS
#define USE_FLASH_M25P16

#define ENABLE_BLACKBOX_LOGGING_ON_SPIFLASH_BY_DEFAULT

Expand Down