IBX-11493: Added language code validation by Steveb-p · Pull Request #736 · ibexa/core

Steveb-p · 2026-03-23T15:40:12Z

🎫 Issue	IBX-11493

Description:

This PR adds metadata to LanguageCreateStruct, with regex condition for the shape of the language code.

Additionally, it refactors LanguageServiceTest code to use newer integration test setup, since the original one was using DummyValidator service, which prevented the test from performing correctly.

Tested manually against a migration:

-   type: language
    mode: create
    metadata:
        languageCode: .
        name: Polish
        enabled: true

Result:

Technically, operations that directly preceed the validator could be moved into validator itself as well (is name empty, is code empty, is code used already?), but I opted not to - since they would introduce more complexity to this PR. Can be done as a follow up if desired.

For QA:

Documentation:

…anguageCreateStruct`

…lid language code tests

…l` instead of `IbexaSolrTestKernel`

…Kernel` and added `CoreSolrTestKernel` implementation

sonarqubecloud · 2026-03-24T10:04:07Z

Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

konradoboza · 2026-03-24T14:34:47Z

src/contracts/Repository/Values/Content/LanguageCreateStruct.php

+    #[Assert\NotBlank]
+    #[Assert\Regex('~^[a-zA-Z\_\-]+$~')]
    public ?string $languageCode = null;


Aren't we making a slight BC break here? Or maybe we are validating if later on on the UI side? POV ping @alongosz.

Technically it can be a BC break if someone has migrations that were executing successfully until this regular expression assertion is introduced.

That said, as mentioned in the Jira ticket, creating certain languages (for example, with . as code) breaks the application entirely.

konradoboza · 2026-03-24T14:35:13Z

tests/integration/Core/Repository/AssertPropertiesTrait.php

+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+


Missing declaring strict types.

konradoboza · 2026-03-24T14:35:39Z

tests/integration/Core/Repository/AssertPropertiesTrait.php

+                    if ($value instanceof ValueObject) {
+                        self::assertStructPropertiesCorrect($value, $actualObject->$propertyName[$key]);
+                    } else {
+                        self::assertPropertiesEqual("$propertyName\[$key\]", $value, $actualObject->$propertyName[$key]);


Suggested change

self::assertPropertiesEqual("$propertyName\[$key\]", $value, $actualObject->$propertyName[$key]);

self::assertPropertiesEqual(

"$propertyName\[$key\]",

$value,

$actualObject->$propertyName[$key]

);

konradoboza · 2026-03-24T14:39:04Z

tests/integration/Core/Repository/AssertPropertiesTrait.php

+     *
+     * If the property type is array, it will be sorted before comparison.
+     *
+     * @TODO: introduced because of randomly failing tests, ref: https://issues.ibexa.co/browse/EZP-21734


I don't think this is relevant anymore, or?

konradoboza · 2026-03-24T14:39:37Z

tests/integration/Core/Repository/LanguageServiceTest.php

-        $languageService->createLanguage($languageCreate);
-        /* END: Use Case */
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage('Argument \'languageCreateStruct\' is invalid: language with the "nor-NO" language code already exists');


Suggested change

$this->expectExceptionMessage('Argument \'languageCreateStruct\' is invalid: language with the "nor-NO" language code already exists');

$this->expectExceptionMessage(

'Argument \'languageCreateStruct\' is invalid: language with the "nor-NO" language code already exists'

);

konradoboza · 2026-03-24T14:40:09Z

tests/integration/Core/Repository/LanguageServiceTest.php

-     * @covers \Ibexa\Contracts\Core\Repository\LanguageService::loadLanguageListById
-     *
-     * @depends testCreateLanguage
+     * @testWith ["."]


Why this instead of dataProvider?

It's simpler.

It will also look a lot better with attributes:

#[TestWith(['EUR'])] #[TestWith(['USD'])] #[TestWith([''])] #[TestWith(['pln'])] public function foo(string $currency) { }

The one you posted looks even better.

konradoboza · 2026-03-24T14:41:39Z

tests/integration/Core/CoreSolrTestKernel.php

+ * @copyright Copyright (C) Ibexa AS. All rights reserved.
+ * @license For full copyright and license information view LICENSE file distributed with this source code.
+ */
+


Suggested change

declare(strict_types=1);

konradoboza · 2026-03-24T14:42:35Z

PHPStan is failing.

Steveb-p force-pushed the ibx-11493/language-code-validation branch from 8a5e2cf to 4e03481 Compare March 23, 2026 16:09

github-actions bot assigned mikadamczyk, alongosz and tischsoic Mar 23, 2026

Steveb-p force-pushed the ibx-11493/language-code-validation branch from 4e03481 to 8dac6a5 Compare March 23, 2026 16:26

Steveb-p changed the base branch from main to fix-phpstan March 23, 2026 16:27

Steveb-p force-pushed the ibx-11493/language-code-validation branch from 8dac6a5 to 85a616c Compare March 23, 2026 16:35

Steveb-p added 5 commits March 23, 2026 18:57

Added assertions to LanguageCreateStruct

a427eae

Refactored LanguageServiceTest and added stricter validation for `L…

ad27abb

…anguageCreateStruct`

Refactored LanguageServiceTest and added stricter validation for `L…

bf432f9

…anguageCreateStruct`

Refactored LanguageServiceTest and added stricter validation for `L…

3306ab0

…anguageCreateStruct`

Refactored LanguageServiceTest to improve parameterization for inva…

4f830d7

…lid language code tests

Steveb-p changed the base branch from fix-phpstan to main March 23, 2026 17:57

Steveb-p force-pushed the ibx-11493/language-code-validation branch from 90267e6 to 4f830d7 Compare March 23, 2026 17:58

Steveb-p requested a review from a team March 23, 2026 18:00

Steveb-p added Bug Something isn't working Ready for review labels Mar 23, 2026

ibexa-workflow-automation-1 bot requested review from ViniTou, alongosz, barw4, ciastektk, konradoboza, mikadamczyk, tbialcz and wiewiurdp and removed request for a team March 23, 2026 18:00

Steveb-p added 2 commits March 24, 2026 10:17

Updated KERNEL_CLASS in PHPUnit configuration to use `CoreTestKerne…

acf21b8

…l` instead of `IbexaSolrTestKernel`

Updated KERNEL_CLASS in PHPUnit configuration to use `IbexaSolrTest…

310c0a8

…Kernel` and added `CoreSolrTestKernel` implementation

konradoboza reviewed Mar 24, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBX-11493: Added language code validation#736

IBX-11493: Added language code validation#736
Steveb-p wants to merge 7 commits intomainfrom
ibx-11493/language-code-validation

Steveb-p commented Mar 23, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

Steveb-p Mar 25, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

Steveb-p Mar 25, 2026

Uh oh!

konradoboza Mar 25, 2026

Uh oh!

konradoboza Mar 24, 2026

Uh oh!

konradoboza commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Steveb-p commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

For QA:

Documentation:

Uh oh!

sonarqubecloud bot commented Mar 24, 2026

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

konradoboza commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Steveb-p commented Mar 23, 2026 •

edited

Loading