Skip to content

IBX-9515: Interactive demos added in Developer Documentation #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

IBX-9515: Interactive demos added in Developer Documentation #2616

merged 2 commits into from
Feb 18, 2025

Conversation

julitafalcondusza
Copy link
Contributor

@julitafalcondusza julitafalcondusza commented Feb 17, 2025 •
edited
Loading

Question Answer
JIRA Ticket (https://issues.ibexa.co/browse/IBX-9515)
Versions 4.6+

Interactive demos added in Developer Documentation

Checklist

  • Text renders correctly
  • Text has been checked with vale
  • Description metadata is up to date
  • Added link to this PR in relevant JIRA ticket or code PR

@github-actions
Copy link

Preview of modified Markdown:

dabrt
dabrt reviewed Feb 18, 2025
View reviewed changes
mnocon
mnocon reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see Tomek's review now and have a bit different view on this :D

Instead of changing the position I'd think about choosing different videos for PB and FB - ones showing how the feature can be used, not how the interface looks like

mnocon
mnocon approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julitafalcondusza julitafalcondusza merged commit 647fe49 into master Feb 18, 2025
6 of 7 checks passed
@julitafalcondusza julitafalcondusza deleted the IBX-9515 branch February 18, 2025 11:00
julitafalcondusza added a commit that referenced this pull request Feb 18, 2025
@julitafalcondusza
IBX-9515: Interactive demos added in Developer Documentation (#2616)
0a9f1ea 
* Interactive demos added in dev-doc

* Fixes after review
@mnocon mnocon mentioned this pull request Mar 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mnocon mnocon mnocon approved these changes

@dabrt dabrt dabrt approved these changes

@adriendupuis adriendupuis Awaiting requested review from adriendupuis

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julitafalcondusza @mnocon @dabrt