Merged
Conversation
crane側で実装されたlifetimeベースの可視化管理機能との整合性を確保するため、 SvgLayerUpdateインターフェースにduration(有効期限)フィールドを追加。 変更内容: - duration?: number フィールドを追加(秒単位、0または未定義=無限) - 表示側での期限管理処理は実装せず(アグリゲーター側で管理) - 将来の拡張に備えた型定義の更新 🤖 Generated with [Claude Code](https://claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
crane側で実装されたlifetimeベースの可視化管理機能との整合性を確保するため、
SvgLayerUpdateインターフェースにdurationフィールドを追加しました。変更内容
SvgLayerUpdateインターフェースにduration?: numberフィールドを追加設計判断
表示側(foxglove_crane_visualizer)では
durationに基づく期限管理処理は実装していません。理由:
/aggregated_svgsには期限切れレイヤーは含まれない今回の変更は将来の拡張に備えた型定義の更新のみです。
テスト
関連
crane側の実装:
SvgLayerUpdate.msgにfloat64 durationフィールドを追加済み🤖 Generated with Claude Code