Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the HTTP client implementation in the Keycloak strategy and adds development tooling. The main functional change replaces direct Faraday.get calls with client.connection.get, which properly utilizes the OAuth2 client's connection object for HTTP requests.
- Replace direct Faraday calls with client.connection calls in the Keycloak strategy
- Add byebug debugger to development dependencies
- Update rubocop and related gems to newer versions
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/omniauth/strategies/keycloak.rb | Replace Faraday.get with client.connection.get for configuration and certificate fetching to properly use the OAuth2 client's connection |
| spec/spec_helper.rb | Add byebug require for debugging support |
| Gemfile | Add byebug gem and update rubocop-related gems to newer versions (1.81.7, 1.26.1, 3.7.0) |
| .rubocop_todo.yml | Increase AbcSize metric threshold from 57 to 61 |
| .gitignore | Add .byebug_history to ignore byebug session files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| gem 'byebug' | ||
| gem 'rake' |
There was a problem hiding this comment.
The byebug gem should be placed in a development/test group rather than at the top level. This ensures it's only loaded in development and test environments, not in production. Consider wrapping it in a group block:
group :development, :test do
gem 'byebug'
end| gem 'byebug' | |
| gem 'rake' | |
| gem 'rake' | |
| group :development, :test do | |
| gem 'byebug' | |
| end |
There was a problem hiding this comment.
@copilot in this case, when there is a .gemspec, the Gemfile is for development and test
bc593b9 to
267df65
Compare
Ensure the configured client options (SSL, proxy, timeouts) are honored by performing GETs via the client connection when fetching the OpenID configuration and the JWKS certificates. Previously these requests used Faraday.get, bypassing the client’s settings. Additionally, add byebug for debugging, bump RuboCop and related cops, update the RuboCop todo, and ignore .byebug_history. Close ifad/omniauth-client#20
267df65 to
aaad8cd
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ensure the configured client options (SSL, proxy, timeouts) are honored
by performing GETs via the client connection when fetching the OpenID
configuration and the JWKS certificates. Previously these requests used
Faraday.get, bypassing the client’s settings.
Additionally, add byebug for debugging, bump RuboCop and related cops,
update the RuboCop todo, and ignore .byebug_history.
Close ifad/omniauth-client#20