Acknowledge Gemfile convention for gem projects#22
Closed
Conversation
Ensure the configured client options (SSL, proxy, timeouts) are honored by performing GETs via the client connection when fetching the OpenID configuration and the JWKS certificates. Previously these requests used Faraday.get, bypassing the client’s settings. Additionally, add byebug for debugging, bump RuboCop and related cops, update the RuboCop todo, and ignore .byebug_history. Close ifad/omniauth-client#20
Member
|
🤌🏼🤌🏼🤌🏼 |
Copilot
AI
changed the title
[WIP] Fix client connection usage for GET requests based on feedback
Acknowledge Gemfile convention for gem projects
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review feedback clarifying that when a
.gemspecexists, theGemfileis conventionally used for development and test dependencies only. No code changes required—the current structure already follows Ruby gem conventions.The
byebuggem placement at the top level of the Gemfile is appropriate because:omniauth-keycloak.gemspecgroup :development, :testblocks are redundant in this context✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.