OF-3219/OF-3220/OF-3221: Add JIRA @see tags to BOSH unit tests#3224
Closed
Copilot wants to merge 2 commits intocopilot/review-xep-0124-implementationfrom
Closed
OF-3219/OF-3220/OF-3221: Add JIRA @see tags to BOSH unit tests#3224Copilot wants to merge 2 commits intocopilot/review-xep-0124-implementationfrom
Copilot wants to merge 2 commits intocopilot/review-xep-0124-implementationfrom
Conversation
…) javadoc Co-authored-by: guusdk <4253898+guusdk@users.noreply.github.com> Agent-Logs-Url: https://github.com/igniterealtime/Openfire/sessions/211fe2b4-5a70-4eeb-a6da-16419237851a
Copilot
AI
changed the title
[WIP] Fix XEP-0124 BOSH compliance: overactivity exception and ack handling
OF-3219/OF-3220/OF-3221: Add JIRA @see tags to BOSH unit tests
Mar 25, 2026
Member
|
This has been superseded by #3229 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
@seejavadoc references to corresponding JIRA issues on each new unit test inHttpBindBodyTest, and onHttpBindBody.getAck(), to satisfy the per-issue traceability requirement raised during review.Tag assignments
testIsPollWhenEmpty/Terminate/Pause→@see OF-3219(overactivity detection)testGetAckWhenPresent/Absent/Invalid/InitialValue,testGetRid,HttpBindBody.getAck()→@see OF-3220(client ACK parsing)OF-3221 (redundant ACK suppression) has no dedicated unit tests in
HttpBindBodyTest; its coverage lives in theHttpSessionlayer.JIRA ticket evaluation
All three tickets accurately describe the issues addressed by the prior commit (
0b4294f):sentElementsnot pruned on client ACK becauseackattribute was never parsedackattribute included in steady-state responses contrary to XEP-0124 §9.1💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.