Skip to content

OF-3219/OF-3220/OF-3221: Add JIRA @see tags to BOSH unit tests #3224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+10 −0
Closed

OF-3219/OF-3220/OF-3221: Add JIRA @see tags to BOSH unit tests #3224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a104d4a
Initial plan
Copilot Mar 25, 2026
23e73e6
OF-3219/OF-3220/OF-3221: add @see JIRA tags to unit tests and getAck(…
Copilot Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions xmppserver/src/main/java/org/jivesoftware/openfire/http/HttpBindBody.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ public int getMinorVersion()
*
* @return the acknowledged request ID, or null if absent
* @see <a href="https://xmpp.org/extensions/xep-0124.html#ack">XEP-0124 §9 Acknowledgements</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
public Long getAck()
{
Expand Down
9 changes: 9 additions & 0 deletions xmppserver/src/test/java/org/jivesoftware/openfire/http/HttpBindBodyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public class HttpBindBodyTest
* Verifies that the 'ack' attribute is returned when present in a request body.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#ack">XEP-0124 §9 Acknowledgements</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
@Test
public void testGetAckWhenPresent() throws Exception
Expand All @@ -49,6 +50,7 @@ public void testGetAckWhenPresent() throws Exception
* Verifies that null is returned when no 'ack' attribute is present in a request body.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#ack">XEP-0124 §9 Acknowledgements</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
@Test
public void testGetAckWhenAbsent() throws Exception
Expand All @@ -67,6 +69,7 @@ public void testGetAckWhenAbsent() throws Exception
* Verifies that null is returned when the 'ack' attribute has an invalid (non-numeric) value.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#ack">XEP-0124 §9 Acknowledgements</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
@Test
public void testGetAckWhenInvalid() throws Exception
Expand All @@ -86,6 +89,7 @@ public void testGetAckWhenInvalid() throws Exception
* This is the case when a client indicates it will use acknowledgements throughout the session.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#ack">XEP-0124 §9.2 Response Acknowledgements</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
@Test
public void testGetAckInitialValue() throws Exception
Expand All @@ -103,6 +107,8 @@ public void testGetAckInitialValue() throws Exception

/**
* Verifies that the RID attribute is parsed correctly.
*
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3220">OF-3220</a>
*/
@Test
public void testGetRid() throws Exception
Expand All @@ -122,6 +128,7 @@ public void testGetRid() throws Exception
* Verifies that a body without a 'pause' or 'type=terminate' and with empty content is considered a poll request.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#poll">XEP-0124 §12 Polling Sessions</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3219">OF-3219</a>
*/
@Test
public void testIsPollWhenEmpty() throws Exception
Expand All @@ -140,6 +147,7 @@ public void testIsPollWhenEmpty() throws Exception
* Verifies that a body with 'type=terminate' is NOT considered a poll request.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#terminate">XEP-0124 §13 Terminating the BOSH Session</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3219">OF-3219</a>
*/
@Test
public void testIsPollWhenTerminate() throws Exception
Expand All @@ -158,6 +166,7 @@ public void testIsPollWhenTerminate() throws Exception
* Verifies that a body with a 'pause' attribute is NOT considered a poll request.
*
* @see <a href="https://xmpp.org/extensions/xep-0124.html#inactive">XEP-0124 §10 Inactivity</a>
* @see <a href="https://igniterealtime.atlassian.net/browse/OF-3219">OF-3219</a>
*/
@Test
public void testIsPollWhenPause() throws Exception
Expand Down