test: add worker metrics tests and coverage infrastructure#1228
test: add worker metrics tests and coverage infrastructure#1228
Conversation
- Add worker-metrics and otel-worker-gauges unit tests for Node SDK - Add worker_metrics and otel_worker_gauges unit tests for Python SDK - Configure vitest coverage (v8 provider, 70% thresholds) for Node SDK - Configure pytest-cov (70% threshold) for Python SDK - Update CI workflow to run tests with coverage reporting - Add coverage output directories to .gitignore
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds test coverage tooling and configs, updates CI to run coverage-enabled tests, extends .gitignore for coverage outputs, and introduces Node and Python unit tests for worker metrics and OTEL gauge behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ytallo
left a comment
There was a problem hiding this comment.
The new test coverage is useful, but making --cov-fail-under=70 part of global pytest addopts will affect every local test invocation. Please move that coverage gate to CI or a dedicated coverage command so focused local runs do not fail for unrelated reasons.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Original pr:
iii-hq/sdk#37
Summary by CodeRabbit
Tests
Chores