Add support for decoding XMP metadata#215
Merged
kornelski merged 1 commit intoimage-rs:masterfrom Sep 3, 2025
Merged
Conversation
kornelski
requested changes
Sep 3, 2025
This change adds support for accessing the XMP metadata stored in a GIF. This extends the StreamingDecoder implementation that now reads this Extension section correctly. Co-authored-by: Rasmus Piorr <piorr@google.com>
kornelski
reviewed
Sep 3, 2025
5 tasks
kornelski
approved these changes
Sep 3, 2025
Member
|
@kornelski Was that intentionally merged already? You seem to have ack'd the proposal to change |
Contributor
|
Yes. The extension data representation is an optimization that can be done in a separate PR. The current data with the first length byte but without others is a mess, so it's a breaking change anyway. |
Contributor
Author
|
JFYI, we followed up on also breaking the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for accessing the XMP metadata stored in a GIF. This extends the StreamingDecoder implementation that now reads this Extension section correctly.