Add support for reading ICC metadata and fix StreamingDecoder::last_ext#216
Merged
197g merged 2 commits intoimage-rs:masterfrom Sep 5, 2025
Merged
Add support for reading ICC metadata and fix StreamingDecoder::last_ext#216197g merged 2 commits intoimage-rs:masterfrom
StreamingDecoder::last_ext#216197g merged 2 commits intoimage-rs:masterfrom
Conversation
The XMP patch that landed recently did a `std::mem::take` on the extension data - this broke the `last_ext` API. Co-authored-by: Rasmus Piorr <piorr@google.com>
197g
reviewed
Sep 4, 2025
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
I'm not too fond of mixing the block lengths with the data but it'll work, I guess? What we should go for is probably the more common option or the one that takes more processing. I'm not sure if that is ICC or XMP but it'll work for now so we can split data and block lengths in a separate PR. A few nits.
197g
requested changes
Sep 4, 2025
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
Just noticed a behavior change that we didn't catch previously. Otherwise looks okay.
kornelski
reviewed
Sep 4, 2025
1c3t3a
force-pushed
the
icc-profile
branch
3 times, most recently
from
91d1c95 to
b8d702c
Compare
kornelski
approved these changes
Sep 5, 2025
Contributor
|
There's "sublock" typo (sub_block) but otherwise looks ok |
197g
approved these changes
Sep 5, 2025
Member
197g
left a comment
197g
left a comment
There was a problem hiding this comment.
👍 me as well with the typo in the internal field fixed.
Member
|
(When releasing this we mustn't forget that it should be |
Co-authored-by: Rasmus Piorr <piorr@google.com>
Contributor
Author
|
Thanks a lot for the review!! :) Happy to see this landing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change builds on #215 and fixes the now unfortunately broken
last_extmethod (sorry) + adds support for the ICC profile.