Skip to content

Relax libzstd version checking #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Relax libzstd version checking #267

wants to merge 2 commits into from

Conversation

georgthegreat
Copy link

Fixes #254

@georgthegreat georgthegreat mentioned this pull request Aug 17, 2025
Open
georgthegreat
georgthegreat commented Aug 17, 2025
View reviewed changes
c-ext/backend_c.c
unsigned our_hardcoded_version = 10507;
if (ZSTD_VERSION_NUMBER != our_hardcoded_version ||
zstd_ver_no != our_hardcoded_version) {
unsigned zstd_version_min = 10506;
Copy link
Author

@georgthegreat georgthegreat Aug 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed in 41f6dfa but it does not seem necessary, there are no actual ABI deps on 1.5.7

@georgthegreat
Copy link
Author

@indygreg, could you, please, take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate zstd version checking at runtime
1 participant
@georgthegreat