Skip to content

Relax libzstd version checking #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Relax libzstd version checking #267

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39441fb
Relax libzstd version checking
georgthegreat Aug 17, 2025
b125ef1
Typo
georgthegreat Aug 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions c-ext/backend_c.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,16 +151,16 @@ void zstd_module_init(PyObject *m) {
*/
PyObject *features = NULL;
PyObject *feature = NULL;
unsigned zstd_ver_no = ZSTD_versionNumber();
unsigned our_hardcoded_version = 10507;
if (ZSTD_VERSION_NUMBER != our_hardcoded_version ||
zstd_ver_no != our_hardcoded_version) {
unsigned zstd_version_min = 10506;
Copy link
Author

@georgthegreat georgthegreat Aug 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed in 41f6dfa but it does not seem necessary, there are no actual ABI deps on 1.5.7

// if either compile-time or runtime version of libzstd is lower than expected, abort initialization
if (ZSTD_VERSION_NUMBER < zstd_version_min ||
ZSTD_versionNumber() < ztd_version_min) {
PyErr_Format(
PyExc_ImportError,
"zstd C API versions mismatch; Python bindings were not "
"compiled/linked against expected zstd version (%u returned by the "
"lib, %u hardcoded in zstd headers, %u hardcoded in the cext)",
zstd_ver_no, ZSTD_VERSION_NUMBER, our_hardcoded_version);
ZSTD_versionNumber(), ZSTD_VERSION_NUMBER, zstd_version_min);
return;
}

Expand Down