prepend values to PATH only when missing#664
Open
vinchatl wants to merge 1 commit intoingydotnet:masterfrom
Open
prepend values to PATH only when missing#664vinchatl wants to merge 1 commit intoingydotnet:masterfrom
vinchatl wants to merge 1 commit intoingydotnet:masterfrom
Conversation
gniumg-source
added a commit
to gniumg-source/git-subrepo
that referenced
this pull request
Feb 9, 2026
Closed
admorgan
requested changes
Feb 9, 2026
|
|
||
| export PATH=$GIT_SUBREPO_ROOT/lib:$PATH | ||
| export MANPATH=$GIT_SUBREPO_ROOT/man:$MANPATH | ||
| if ! [[ "$PATH" =~ "$GIT_SUBREPO_ROOT/lib:" ]]; then |
Collaborator
There was a problem hiding this comment.
This won't work because .rc isn't a bash file. As can be see in lines previous to this one it is used by many shells and =~ is a bash only operator. This needs to use posix shell commands to accomplish. I agree that this unconditionally updates your path, but you must be doing a lot of sourcing your bashrc before you would notice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes cases where executing
source ~/.bashrc(after a change unrelated to git-subrepo) would prepend the git-subrepo root to the PATH variable each time the.rcfile is called, leading to an always increasing PATH size with only duplicates.Implementation is inspired by default
.bashrcwith pattern-matching on PATH variable.