Skip to content

prepend values to PATH only when missing #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinchatl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

prepend values to PATH only when missing #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,14 @@ GIT_SUBREPO_ROOT=$(
) || return
export GIT_SUBREPO_ROOT

export PATH=$GIT_SUBREPO_ROOT/lib:$PATH
export MANPATH=$GIT_SUBREPO_ROOT/man:$MANPATH
if ! [[ "$PATH" =~ "$GIT_SUBREPO_ROOT/lib:" ]]; then
Copy link
Copy Markdown
Collaborator

@admorgan admorgan Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work because .rc isn't a bash file. As can be see in lines previous to this one it is used by many shells and =~ is a bash only operator. This needs to use posix shell commands to accomplish. I agree that this unconditionally updates your path, but you must be doing a lot of sourcing your bashrc before you would notice.

PATH="$GIT_SUBREPO_ROOT/lib:$PATH"
fi
export PATH

if ! [[ "$MANPATH" =~ "$GIT_SUBREPO_ROOT/man:" ]]; then
MANPATH="$GIT_SUBREPO_ROOT/man:$MANPATH"
fi
export MANPATH

source "$GIT_SUBREPO_ROOT/share/enable-completion.sh"