Skip to content

Conversation

jmgilman
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue) if applicable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: if applicable

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

List of new dependencies: if applicable

Provide a list of newly added dependencies in this PR, with the description of what are they doing and why do we need them.

  • Crate A: description
  • Crate B: description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kukkok3 kukkok3 self-requested a review July 14, 2025 08:51
Copy link
Contributor

@kukkok3 kukkok3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 enabled auto-merge (squash) July 14, 2025 09:27
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kukkok3 kukkok3 disabled auto-merge July 15, 2025 07:56
@kukkok3 kukkok3 changed the title chore: adds additional prometheus metrics to voting-node chore: adds additional prometheus metrics to voting-node | NPG-000 Jul 15, 2025
@kukkok3 kukkok3 enabled auto-merge (squash) July 16, 2025 08:32
@kukkok3 kukkok3 merged commit 75b2823 into main Jul 16, 2025
44 of 46 checks passed
@kukkok3 kukkok3 deleted the adds-voting-node-metrics branch July 16, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants