Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

Description

Chaning visibility scope for the Cip0134UriSet by making some methods of Cip0134UriSet, Cip509 and RegistrationChain types public.

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@Mr-Leshiy Mr-Leshiy changed the base branch from main to feat/rbac November 20, 2025 10:15
@Mr-Leshiy Mr-Leshiy self-assigned this Nov 20, 2025
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team labels Nov 20, 2025
@Mr-Leshiy Mr-Leshiy moved this from New to 👀 In review in Catalyst Nov 20, 2025
@github-actions
Copy link
Contributor

📚 Docs Preview

The docs for this PR can be previewed at the following URL:

https://docs.dev.projectcatalyst.io/libs/feat/cip509-uris

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 566/566}$ | ${\color{red}Fail: 0/566}$ |

@Mr-Leshiy Mr-Leshiy merged commit e4e5a50 into feat/rbac Nov 20, 2025
23 of 24 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/cip509-uris branch November 20, 2025 10:32
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Nov 20, 2025
Mr-Leshiy added a commit that referenced this pull request Nov 25, 2025
* feat(rust/rbac-registration): Add provider trait for `RegistrationChain` (#586)

* initial

* feat: provider

* feat: update chain

* feat: start_new_chain

* feat: merge validation result struct into cip509

* feat: exports

* feat: return new chain

* chore: return success object

* fix: older version

* feat: cat id in payload

* fix: new version

* chore: lintfix

* chore: remove persistent arguments

* tmp

* chore: complete moving to central module

* feat: ref fn

* chore: merge methods

* chore: minor

* feat: export modified chains

* chore: minor comment

* chore: rbac update logic

* chore: isolation

* chore: validation and lintfix

* docs: remove error doc

* chore: minor refactor

* fix: comments

* chore: validation function return

* Update rust/rbac-registration/src/providers.rs

Co-authored-by: Alex Pozhylenkov <[email protected]>

---------

Co-authored-by: Alex Pozhylenkov <[email protected]>

* feat(rust/rbac-registration): RBAC stolen `StakeAddress` handling. (#631)

* wip

* wip

* wip

* wip

* revert

* wip

* add stolen_uris field

* wip

* wip

* wip

* fix

* wip

* wip

* fix spelling

* fix

* wip

* wip

* wip

* wip

* cleanup

* fix test

* fix clippy

* wip

* wip

* fix

* wip

* fix clippy

* fix

* wip

* wip

* fix clippy

* make Cip0134UriSet private (#655)

* wip (#658)

* Update rust/rbac-registration/src/registration/cardano/mod.rs

Co-authored-by: Rafał Chabowski <[email protected]>

* fix suggestions

* wip

* fix clippy

* comments fixes

* rename state to Provider

* fix fmt

* cleanup `check_signing_public_key`

* Update rust/rbac-registration/src/cardano/cip509/cip509.rs

Co-authored-by: bkioshn <[email protected]>

* fix fmt

* fix fmt

---------

Co-authored-by: Apisit Ritruengroj <[email protected]>
Co-authored-by: Rafał Chabowski <[email protected]>
Co-authored-by: bkioshn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants