ghc-9.2 and ghc-9.10.2 support #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
changed the title
Collaborator
Author
|
@jasagredo could you review it? |
There was a problem hiding this comment.
Pull Request Overview
This PR updates package configurations to support newer GHC versions by bumping base bounds, adding conditional extensions for older compilers, and refreshing the Cabal index and allow-newer settings.
- Bump
baselower bound to require at least base-4.16 - Add
GADTsextension for ghc < 9.4 in two libraries - Update
index-stateand adjust theallow-newercondition incabal.project
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| io-sim/io-sim.cabal | Raised base lower bound from 4.9 to 4.16 |
| io-classes/io-classes.cabal | Raised base lower bound, added if impl(ghc < 9.4) GADTs blocks |
| cabal.project | Bumped index-state timestamp and changed allow-newer guard |
Comments suppressed due to low confidence (2)
io-sim/io-sim.cabal:65
- The upper bound '<4.22' excludes base versions shipped with GHC 9.8 and above (including GHC 9.10.2). Consider extending it to '<4.24' or '<5' to match the intended support range.
build-depends: base >=4.16 && <4.22,
cabal.project:15
- The condition was updated to 'ghc >= 9.12', but PR metadata mentions GHC 9.10.2 support. Verify whether this should remain '>= 9.10.2' or be aligned with the new target version.
if impl (ghc >= 9.12)
jasagredo
approved these changes
Jun 2, 2025
Contributor
jasagredo
left a comment
jasagredo
left a comment
There was a problem hiding this comment.
Let's get this released and then we release fs-sim and fs-api.
Collaborator
Author
|
I needed to bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.