fix: pass autoFocus prop to uncontrolled pw input element #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchappell
approved these changes
Aug 13, 2024
|
| @@ -68,6 +69,7 @@ export const UncontrolledPasswordInput = ({ | |||
| type={isPasswordVisible ? 'text' : 'password'} | |||
| required={required} | |||
| placeholder="" | |||
| autoFocus={autoFocus} | |||
There was a problem hiding this comment.
I am ok with it as an interim solution but I have to point out that this technically may not work 100% of the time: https://blog.logrocket.com/how-to-autofocus-using-react-hooks/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test in
lacewas failing after replacing Password with this component. Tested it with this change.