Skip to content

fix: pass autoFocus prop to uncontrolled pw input element #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: pass autoFocus prop to uncontrolled pw input element #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/design-system/password-box/uncontrolled-password-box-input.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export const UncontrolledPasswordInput = ({
errorMessage = '',
containerClassName = '',
onChange,
autoFocus,
defaultIsPasswordVisible = false,
containerStyle,
testId,
Expand Down Expand Up @@ -68,6 +69,7 @@ export const UncontrolledPasswordInput = ({
type={isPasswordVisible ? 'text' : 'password'}
required={required}
placeholder=""
autoFocus={autoFocus}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with it as an interim solution but I have to point out that this technically may not work 100% of the time: https://blog.logrocket.com/how-to-autofocus-using-react-hooks/

className={cn(cx.input, { [cx.largeDots]: !isPasswordVisible })}
disabled={disabled}
name={name}
Expand Down