Skip to content

Remove source code button from modules' encoding panel #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 74 commits into from
Oct 3, 2025
Merged

Remove source code button from modules' encoding panel #1425

merged 74 commits into from
Oct 3, 2025

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Sep 17, 2025 •
edited
Loading

m7pr added 30 commits July 2, 2025 10:26
@m7pr
update DESCRIPTION Remote fields
28a6f94
@m7pr
tm_a_gee
ca5274f
@m7pr
remove filter_panel_api from tm_a_gee
ea1fd23
@m7pr
tm_g_barchart_simple
1849293
@m7pr
add a section for modules code
afad535
@m7pr
add section header for modules code to tm_a_gee to separate data filt…
d5fff6f 
…ering and code prapartioans
@m7pr
tm_g_ci
5ed9437
@m7pr
tm_g_km
e34e82c
@m7pr
few more plots modules
cfd5e4b
@m7pr
move title creation for tm_a_gee
07826d5
@m7pr
rewrite tm_a_mmrm
9842177
@m7pr
add sections to tm_g_barchart
ca45b38
@m7pr
tm_t_ancova
6cfbc77
@m7pr
tm_t_binary_outcome
f50bde2
@m7pr
tm_t_coxreg
b988b7b
@m7pr
tm_t_events
9ab81f0
@m7pr
tm_t_logistic
f420f24
@m7pr
tm_t_summary_by
0d940fa
@m7pr
tm_t_summary
4f901d4
@m7pr
tm_t_tte
54fd201
@m7pr
tm_t_events_by_grade
7732928
@m7pr
tm_t_events_patyear
4697ac8
@m7pr
tm_t_events_summary
1d8bf6b
@m7pr
tm_t_exposure
c379d66
@m7pr
return decorated_table_q in tm_t_events_by_grade
7974973
@m7pr
tm_t_mult_events
aebde47
@m7pr
tm_t_pp_basic_info
7053f94
@m7pr
tm_t_pp_laboratory
91ee548
@m7pr
tm_t_pp_medical_history
018d50c
@m7pr
tm_t_pp_prior_medication
bb8af01
@averissimo
Copy link
Contributor Author

averissimo commented Sep 17, 2025

@llrs-roche here's the PR for TMC

Thanks for flagging this on: insightsengineering/teal#1592 (comment)

@averissimo averissimo changed the title chore: remove source code button from modules Remove source code button from modules' encoding panel Sep 17, 2025
@averissimo averissimo mentioned this pull request Sep 17, 2025
Merged
This was referenced Sep 17, 2025
Merged
Merged
@llrs-roche
Copy link
Contributor

llrs-roche commented Sep 17, 2025

@llrs-roche here's the PR for TMC

Thanks for flagging this on: insightsengineering/teal#1592 (comment)

Thanks for the ping @averissimo. I think I was using teal's example_module which still has the teal.widgets::verbatim_popup_srv call in the server side of the module.

@averissimo
Copy link
Contributor Author

averissimo commented Sep 17, 2025

@llrs-roche that has also been updated on the show-r-code branch 😅

Base automatically changed from teal_reportable to main September 25, 2025 09:14
@averissimo
fix: remove add to reporter button
4167870
@averissimo
docs: remove section with documentation that is not yet released
de8ca1d
@averissimo
Revert "docs: remove section with documentation that is not yet relea…
202ea85 
…sed"

This reverts commit de8ca1d.
@averissimo
Merge remote-tracking branch 'origin/main' into 1534-show_r_code@teal…
1450ea9 
…_reportable@main

* origin/main:
  [skip actions] Bump version to 0.11.1.9007
  Removes 2 reporter buttons (#1428)
  [skip actions] Bump version to 0.11.1.9006
  📑 Reporter Refactor: Adds support for new `teal_report` and `teal_card` class (#1392)
  [skip actions] Bump version to 0.11.1.9005
  Address issues related to testing with shinytest2 the examples (#1423)
  [skip actions] Bump version to 0.11.1.9004
  Change R dependency version to 4.4.0 (#1422)
  [skip actions] Bump version to 0.11.1.9003
  Add labels back only if needed (#1426)
@averissimo averissimo marked this pull request as ready for review October 3, 2025 08:26
llrs-roche
llrs-roche approved these changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks pass with current main branches of packages.

I checked a couple of modules and they don't have the button (as expected after a search).
I didn't find any code that would require to be removed.

@llrs-roche llrs-roche self-assigned this Oct 3, 2025
averissimo added a commit to insightsengineering/teal.goshawk that referenced this pull request Oct 3, 2025
@averissimo
Remove source code button from modules' encoding panel (#366)
53cf1e9 
# Pull Request

- Part of insightsengineering/teal#1534

Companion to:
- insightsengineering/teal#1592
- insightsengineering/teal.reporter#401

Other similar PRs in modules:
- insightsengineering/teal.modules.clinical#1425
- insightsengineering/teal.modules.general#917
- #366
- insightsengineering/teal.osprey#319
averissimo added a commit to insightsengineering/teal.osprey that referenced this pull request Oct 3, 2025
@averissimo
Remove source code button from modules' encoding panel (#319)
5f0735c 
# Pull Request

- Part of insightsengineering/teal#1534

Companion to:
- insightsengineering/teal#1592
- insightsengineering/teal.reporter#401

Other similar PRs in modules:
- insightsengineering/teal.modules.clinical#1425
- insightsengineering/teal.modules.general#917
- insightsengineering/teal.goshawk#366
- #319
@averissimo averissimo enabled auto-merge (squash) October 3, 2025 12:40
@averissimo averissimo marked this pull request as draft October 3, 2025 12:43
auto-merge was automatically disabled October 3, 2025 12:43

Pull request was converted to draft

@averissimo averissimo marked this pull request as ready for review October 3, 2025 12:44
@averissimo averissimo enabled auto-merge (squash) October 3, 2025 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025 •
edited
Loading

Unit Tests Summary

  1 files   71 suites   12s ⏱️
734 tests 155 ✅ 579 💤 0 ❌
874 runs  176 ✅ 698 💤 0 ❌

Results for commit 1556eae.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💔 $1.60$ $+5.43$ $0$ $-115$ $0$ $0$
tm_t_glm_counts 💔 $0.03$ $+24.57$ $+3$ $-2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tm_t_glm_counts 💔 $0.01$ $+12.15$ e2e_tm_t_glm_counts_Module_initializes_in_teal_without_errors_and_produces_table_output.
tm_t_glm_counts 💔 $0.02$ $+12.42$ e2e_tm_t_glm_counts_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 8c001e0

♻️ This comment has been updated with latest results.

@averissimo averissimo merged commit 0bd7835 into main Oct 3, 2025
25 of 26 checks passed
@averissimo averissimo deleted the 1534-show_r_code@teal_reportable@main branch October 3, 2025 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@llrs-roche llrs-roche llrs-roche approved these changes

Assignees

@llrs-roche llrs-roche

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@averissimo @llrs-roche @m7pr