Skip to content

Conversation

@averissimo averissimo marked this pull request as ready for review October 3, 2025 07:13
averissimo added a commit to insightsengineering/teal.modules.clinical that referenced this pull request Oct 3, 2025
# Pull Request

- Part of insightsengineering/teal#1534

Companion to:
- insightsengineering/teal#1592
- insightsengineering/teal.reporter#401

Other similar PRs in modules:
- #1425
- insightsengineering/teal.modules.general#917
- insightsengineering/teal.goshawk#366
- insightsengineering/teal.osprey#319

---------

Signed-off-by: Marcin <[email protected]>
Co-authored-by: m7pr <[email protected]>
Co-authored-by: Marcin <[email protected]>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@llrs-roche llrs-roche self-assigned this Oct 3, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code blocks are removed correctly.

I left some comments that might not be related to this PR.
But I also found that the module about variable browser on the report it is not displayed correctly:

Image

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

Unit Tests Summary

  1 files  23 suites   1s ⏱️
151 tests 36 ✅ 115 💤 0 ❌
194 runs  79 ✅ 115 💤 0 ❌

Results for commit 0e6e86d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    866     866  0.00%    141-1134
R/tm_a_regression.R             752     752  0.00%    180-1028
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            321     321  0.00%    161-548
R/tm_g_bivariate.R              675     411  39.11%   332-791, 832, 943, 960, 978, 989-1011
R/tm_g_distribution.R          1107    1107  0.00%    154-1403
R/tm_g_response.R               346     346  0.00%    179-595
R/tm_g_scatterplot.R            710     710  0.00%    261-1066
R/tm_g_scatterplotmatrix.R      273     254  6.96%    200-502, 563, 577
R/tm_missing_data.R            1081    1081  0.00%    124-1381
R/tm_outliers.R                1023    1023  0.00%    163-1337
R/tm_t_crosstable.R             264     264  0.00%    177-483
R/tm_variable_browser.R         788     783  0.63%    89-1025, 1063-1246
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8908    8544  4.09%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/tm_a_pca.R                    -10     -10  +100.00%
R/tm_a_regression.R             -10     -10  +100.00%
R/tm_g_association.R            -10     -10  +100.00%
R/tm_g_bivariate.R              -10     -10  +0.57%
R/tm_g_distribution.R            -9      -9  +100.00%
R/tm_g_response.R               -10     -10  +100.00%
R/tm_g_scatterplot.R            -10     -10  +100.00%
R/tm_g_scatterplotmatrix.R      -10     -10  +0.25%
R/tm_missing_data.R             -18     -18  +100.00%
R/tm_outliers.R                  -9      -9  +100.00%
R/tm_t_crosstable.R              -9      -9  +100.00%
TOTAL                          -115    -115  +0.05%

Results for commit: 0e6e86d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr
Copy link
Contributor

m7pr commented Oct 7, 2025

@llrs-roche here #917 (review)
good catch. It is improperly displayed for the downloaded report.

Downloaded report

image

Report previewer

image

@m7pr
Copy link
Contributor

m7pr commented Oct 7, 2025

Hey @llrs-roche I created a fix for the grob print in the report insightsengineering/teal.reporter#417

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created one fix and 2 issues that were discovered during testing of this PR, but are no related

insightsengineering/teal.reporter#417
insightsengineering/teal.reporter#418
#925

@m7pr m7pr enabled auto-merge (squash) October 7, 2025 13:01
@m7pr m7pr merged commit 80deb96 into main Oct 7, 2025
70 of 74 checks passed
@m7pr m7pr deleted the 1534-show_r_code@main branch October 7, 2025 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants