Skip to content

Conversation

@llrs-roche
Copy link
Contributor

Pull Request

Part of #1440
Companion of #1441


testthat::expect_equal(
app_driver$get_text("#teal-teal_modules-active_tab .active > a"),
app_driver$get_text("#teal-teal_modules-active_module_id * .teal-modules-tree * .nav-link"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only realized of this later and used it in a different PR but I wanted to ask for your feedback.
I like that this one uses the id but yours is shorter which is also a plus.
Maybe the one with id is more tightly coupled and works better as a test if the UI changes but I let you decide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llrs-roche my preference is the shorter the better : P
once you change this. you can merge to my branch

@m7pr m7pr self-assigned this Nov 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Unit Tests Summary

    1 files  ±    0     71 suites  ±0   2h 20m 32s ⏱️ + 2h 19m 10s
  734 tests ±    0    362 ✅ +  207  117 💤  - 462  226 ❌ +226  29 🔥 +29 
1 937 runs  +1 063  1 418 ✅ +1 242  117 💤  - 581  373 ❌ +373  29 🔥 +29 

For more details on these failures and errors, see this check.

Results for commit 06cfc20. ± Comparison against base commit d200e5f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2025

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $0.23$ $+3.62$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💔 $0.66$ $+7.85$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $0.33$ $+2.79$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💔 $0.20$ $+1.22$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $0.25$ $+2.79$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $0.19$ $+2.86$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $0.38$ $+3.20$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💔 $0.14$ $+1.10$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $0.25$ $+1.89$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $0.37$ $+4.89$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $0.33$ $+7.13$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $0.16$ $+1.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $0.13$ $+1.16$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $0.12$ $+1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💔 $0.37$ $+2.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $0.14$ $+1.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💔 $0.17$ $+1.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $0.13$ $+1.55$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $0.11$ $+2.74$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $0.13$ $+2.93$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $0.22$ $+1.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $0.16$ $+1.56$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $0.11$ $+1.33$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $0.17$ $+1.95$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $0.13$ $+1.93$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💔 $0.11$ $+1.34$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $0.15$ $+1.52$ $0$ $0$ $0$ $0$

Results for commit 9f6e8f7

♻️ This comment has been updated with latest results.

llrs-roche added a commit that referenced this pull request Nov 25, 2025
# Pull Request

Fixes #1440 
Companion of #1441 


Test with `devtools::test(filter = "tm_t_shift_by")`

Note that here the tests use the class of the elements instead of the id
of the elements like in other PR (#1443, #1442 )
@llrs-roche llrs-roche merged commit d78854b into bring_tests Nov 26, 2025
11 of 20 checks passed
@llrs-roche llrs-roche deleted the tm_t_events branch November 26, 2025 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants