Fixes plot settings that did not have an accordion wrapper

[averissimo]

Pull Request

• Fixes [Question]: Outlier module: plot setting is unavailable despite showing title? #937

Companion PR:

• Fixes plot settings that did not have an accordion wrapper teal.modules.clinical#1436
• Fixes plot settings that did not have an accordion wrapper #939

Note to reviewer

ℹ️ Please check each example app of the affected module

Changes description

• Adds bslib::accordion wrapper to plot settings that were missing
• Check other modules / encoding if there are any that have the same problem

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    864     864  0.00%    141-1132
R/tm_a_regression.R             751     751  0.00%    180-1027
R/tm_data_table.R               201     201  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            320     320  0.00%    161-547
R/tm_g_bivariate.R              664     406  38.86%   332-786, 827, 932, 949, 967, 978-1000
R/tm_g_distribution.R          1106    1106  0.00%    156-1404
R/tm_g_response.R               345     345  0.00%    179-594
R/tm_g_scatterplot.R            709     709  0.00%    261-1065
R/tm_g_scatterplotmatrix.R      272     253  6.99%    200-501, 562, 576
R/tm_missing_data.R            1080    1080  0.00%    124-1380
R/tm_outliers.R                1029    1029  0.00%    162-1341
R/tm_t_crosstable.R             263     263  0.00%    177-482
R/tm_variable_browser.R         787     782  0.64%    89-1024, 1062-1245
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8893    8535  4.03%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/tm_a_pca.R                  -1      -1  +100.00%
R/tm_outliers.R               +3      +3  +100.00%
R/tm_variable_browser.R       -1      -1  +0.00%
TOTAL                         +1      +1  -0.00%

Results for commit: 9ee851c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Tests Summary

  1 files   23 suites   25m 0s ⏱️
151 tests 140 ✅ 5 💤 0 ❌ 6 🔥
456 runs  445 ✅ 5 💤 0 ❌ 6 🔥

For more details on these errors, see this check.

Results for commit 9ee851c.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_g_bivariate	💚	$91.46$	$-1.49$	$0$	$0$	$0$	$0$
shinytest2-tm_g_response	💚	$38.93$	$-1.53$	$0$	$0$	$0$	$0$
shinytest2-tm_g_scatterplot	💚	$86.05$	$-2.20$	$0$	$0$	$0$	$0$
shinytest2-tm_misssing_data	💔	$57.11$	$+5.33$	$+5$	$0$	$0$	$-1$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_g_bivariate	💚	$37.08$	$-1.12$	e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_scatterplot	💚	$46.65$	$-1.02$	e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_misssing_data	💔	$7.90$	$+5.81$	e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_

Results for commit d592d42

♻️ This comment has been updated with latest results.

[osenan]

The changes look ok, now I am checking each module in the app

[osenan]

Good work!

I've checked in exploratory teal.gallery app that the modules look good.
Only the module variable browser I cannot check because in this branch still has an error. I guess when the fix is merged I will be able to test it.

[averissimo]

Merging this as error is being solved in #922