changed TealAppDriver constructor #927

gogonzo · 2025-10-10T11:58:41Z

Followup after insightsengineering/teal#1623

TealAppDriver now accepts teal_app instead of data, modules, ...
TealAppDriver has method namespaces(is_selector = FALSE) in favour of active_module_id, active_module_ns, ... Teal app driver changes teal#1633
Please run the tests with options(TESTING_DEPTH=5)

github-actions · 2025-10-10T12:07:43Z

Unit Tests Summary

1 files 23 suites 17m 5s ⏱️
151 tests 146 ✅ 5 💤 0 ❌
473 runs 468 ✅ 5 💤 0 ❌

Results for commit 7a8e0d7.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-10T12:08:37Z

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -------------------------------------------
R/tm_a_pca.R                    866     866  0.00%    141-1134
R/tm_a_regression.R             752     752  0.00%    180-1028
R/tm_data_table.R               200     200  0.00%    100-348
R/tm_file_viewer.R              172     172  0.00%    47-254
R/tm_front_page.R               143     132  7.69%    77-246
R/tm_g_association.R            321     321  0.00%    161-548
R/tm_g_bivariate.R              671     407  39.34%   332-787, 828, 939, 956, 974, 985-1007
R/tm_g_distribution.R          1107    1107  0.00%    156-1405
R/tm_g_response.R               346     346  0.00%    179-595
R/tm_g_scatterplot.R            710     710  0.00%    261-1066
R/tm_g_scatterplotmatrix.R      273     254  6.96%    200-502, 563, 577
R/tm_missing_data.R            1081    1081  0.00%    124-1381
R/tm_outliers.R                1027    1027  0.00%    162-1339
R/tm_t_crosstable.R             264     264  0.00%    177-483
R/tm_variable_browser.R         788     783  0.63%    89-1025, 1063-1246
R/utils.R                       185     120  35.14%   87-249, 278-304, 316-325, 330, 344-363, 452
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8908    8544  4.09%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  -------
R/tm_g_bivariate.R       -4      -4  +0.23%
TOTAL                    -4      -4  +0.00%

Results for commit: 7a8e0d7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

m7pr · 2025-10-10T12:11:13Z

Remember to install teal before, and then run tests in tmg.

m7pr

Hey, no issues after reinstalling teal

> options(TESTING_DEPTH = 5);devtools::test()
ℹ Testing teal.modules.general
Registered S3 method overwritten by 'teal':
  method        from      
  c.teal_slices teal.slice
Registered S3 methods overwritten by 'ggpp':
  method                  from   
  heightDetails.titleGrob ggplot2
  widthDetails.titleGrob  ggplot2
Registered S3 method overwritten by 'tern':
  method   from 
  tidy.glm broom
✔ | F W  S  OK | Context
✔ |     37   0 | examples                                                               
✔ |     11   0 | shinytest2-tm_a_pca                                                    
✔ |      7   0 | shinytest2-tm_a_regression                                             
✔ |      4   0 | shinytest2-tm_data_table                                               
✔ |      4   0 | shinytest2-tm_file_viewer                                              
✔ |      3   0 | shinytest2-tm_front_page                                               
✔ |      4   0 | shinytest2-tm_g_association                                            
✔ |      4   0 | shinytest2-tm_g_bivariate                                              
✔ |      3   0 | shinytest2-tm_g_distribution                                           
✔ |      4   0 | shinytest2-tm_g_response                                               
✔ |      5   0 | shinytest2-tm_g_scatterplot                                            
✔ |      4   0 | shinytest2-tm_g_scatterplotmatrix                                      
✔ |      5   0 | shinytest2-tm_misssing_data                                            
✔ |     10   0 | shinytest2-tm_outliers                                                 
✔ |      4   0 | shinytest2-tm_t_crosstable                                             
✔ |      6   0 | shinytest2-tm_variable_browser                                         
✔ |         18 | tm_g_bivariate                                                         
✔ |         12 | utils                                                                  
✔ |         21 | bivariate_ggplot_call                                                  
✔ |          4 | front_page                                                             
✔ |         15 | g_expert_cl                                                            
✔ |          6 | scatterplotmatrix_get_stats                                            
✔ |          3 | variable_browser                                                       

══ Results ═════════════════════════════════════════════════════════════════════════════
Duration: 1.6 s

── Skipped tests (115) ─────────────────────────────────────────────────────────────────
• chromium (115): test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-examples.R:144:7, test-examples.R:144:7,
  test-examples.R:144:7, test-shinytest2-tm_a_pca.R:35:3,
  test-shinytest2-tm_a_pca.R:60:3, test-shinytest2-tm_a_pca.R:78:3,
  test-shinytest2-tm_a_pca.R:96:3, test-shinytest2-tm_a_pca.R:114:3,
  test-shinytest2-tm_a_pca.R:136:3, test-shinytest2-tm_a_pca.R:160:3,
  test-shinytest2-tm_a_pca.R:179:3, test-shinytest2-tm_a_pca.R:194:3,
  test-shinytest2-tm_a_pca.R:227:3, test-shinytest2-tm_a_pca.R:246:3,
  test-shinytest2-tm_a_regression.R:49:3, test-shinytest2-tm_a_regression.R:68:3,
  test-shinytest2-tm_a_regression.R:88:3, test-shinytest2-tm_a_regression.R:102:3,
  test-shinytest2-tm_a_regression.R:130:3, test-shinytest2-tm_a_regression.R:143:3,
  test-shinytest2-tm_a_regression.R:172:3, test-shinytest2-tm_data_table.R:24:3,
  test-shinytest2-tm_data_table.R:39:3, test-shinytest2-tm_data_table.R:49:3,
  test-shinytest2-tm_data_table.R:86:3, test-shinytest2-tm_file_viewer.R:20:3,
  test-shinytest2-tm_file_viewer.R:46:3, test-shinytest2-tm_file_viewer.R:63:3,
  test-shinytest2-tm_file_viewer.R:86:3, test-shinytest2-tm_front_page.R:25:3,
  test-shinytest2-tm_front_page.R:50:3, test-shinytest2-tm_front_page.R:63:3,
  test-shinytest2-tm_g_association.R:48:3, test-shinytest2-tm_g_association.R:67:3,
  test-shinytest2-tm_g_association.R:89:3, test-shinytest2-tm_g_association.R:99:3,
  test-shinytest2-tm_g_bivariate.R:88:3, test-shinytest2-tm_g_bivariate.R:117:3,
  test-shinytest2-tm_g_bivariate.R:159:3, test-shinytest2-tm_g_bivariate.R:196:3,
  test-shinytest2-tm_g_distribution.R:48:3, test-shinytest2-tm_g_distribution.R:73:3,
  test-shinytest2-tm_g_distribution.R:111:3, test-shinytest2-tm_g_response.R:43:3,
  test-shinytest2-tm_g_response.R:62:3, test-shinytest2-tm_g_response.R:93:3,
  test-shinytest2-tm_g_response.R:105:3, test-shinytest2-tm_g_scatterplot.R:87:3,
  test-shinytest2-tm_g_scatterplot.R:114:3, test-shinytest2-tm_g_scatterplot.R:135:3,
  test-shinytest2-tm_g_scatterplot.R:155:3, test-shinytest2-tm_g_scatterplot.R:168:3,
  test-shinytest2-tm_g_scatterplotmatrix.R:48:3,
  test-shinytest2-tm_g_scatterplotmatrix.R:66:3,
  test-shinytest2-tm_g_scatterplotmatrix.R:79:3,
  test-shinytest2-tm_g_scatterplotmatrix.R:107:3,
  test-shinytest2-tm_misssing_data.R:39:3, test-shinytest2-tm_misssing_data.R:61:3,
  test-shinytest2-tm_misssing_data.R:94:3, test-shinytest2-tm_misssing_data.R:132:3,
  test-shinytest2-tm_misssing_data.R:163:3, test-shinytest2-tm_outliers.R:52:3,
  test-shinytest2-tm_outliers.R:73:3, test-shinytest2-tm_outliers.R:110:3,
  test-shinytest2-tm_outliers.R:128:3, test-shinytest2-tm_outliers.R:144:3,
  test-shinytest2-tm_outliers.R:162:3, test-shinytest2-tm_outliers.R:179:3,
  test-shinytest2-tm_outliers.R:195:3, test-shinytest2-tm_outliers.R:247:3,
  test-shinytest2-tm_outliers.R:296:3, test-shinytest2-tm_t_crosstable.R:47:3,
  test-shinytest2-tm_t_crosstable.R:65:3, test-shinytest2-tm_t_crosstable.R:76:3,
  test-shinytest2-tm_t_crosstable.R:100:3, test-shinytest2-tm_variable_browser.R:30:3,
  test-shinytest2-tm_variable_browser.R:71:3,
  test-shinytest2-tm_variable_browser.R:104:3,
  test-shinytest2-tm_variable_browser.R:159:3,
  test-shinytest2-tm_variable_browser.R:175:3,
  test-shinytest2-tm_variable_browser.R:203:3

[ FAIL 0 | WARN 0 | SKIP 115 | PASS 79 ]

m7pr · 2025-10-10T12:33:43Z

sorry, looks like my testing strategy skips shinytests. will try again

gogonzo · 2025-10-10T12:45:18Z

There are skip("chromium") everywhere. They skip always, besides there are many failures (including failures caused by teal 1.0). I'm fixing them but it will take some time

github-actions · 2025-10-14T09:27:49Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
examples	💔	$0.54$	$+5.17$	$+1$	$-36$	$0$	$0$
shinytest2-tm_a_pca	💔	$0.16$	$+165.29$	$+38$	$-11$	$0$	$0$
shinytest2-tm_a_regression	💔	$0.11$	$+74.83$	$+24$	$-7$	$0$	$0$
shinytest2-tm_data_table	💔	$0.05$	$+31.06$	$+6$	$-4$	$0$	$0$
shinytest2-tm_file_viewer	💔	$0.05$	$+34.70$	$+9$	$-4$	$0$	$0$
shinytest2-tm_front_page	💔	$0.04$	$+27.58$	$+6$	$-3$	$0$	$0$
shinytest2-tm_g_bivariate	💔	$0.05$	$+94.98$	$+40$	$-4$	$0$	$0$
shinytest2-tm_g_distribution	💔	$0.04$	$+72.63$	$+17$	$-3$	$0$	$0$
shinytest2-tm_g_response	💔	$0.05$	$+40.71$	$+13$	$-4$	$0$	$0$
shinytest2-tm_g_scatterplot	💔	$0.06$	$+89.34$	$+30$	$-5$	$0$	$0$
shinytest2-tm_g_scatterplotmatrix	💔	$0.05$	$+37.77$	$+5$	$-4$	$0$	$0$
shinytest2-tm_misssing_data	💔	$0.07$	$+66.83$	$+17$	$-5$	$0$	$0$
shinytest2-tm_outliers	💔	$0.13$	$+158.27$	$+51$	$-10$	$0$	$0$
shinytest2-tm_t_crosstable	💔	$0.05$	$+41.41$	$+5$	$-4$	$0$	$0$
shinytest2-tm_variable_browser	💔	$0.08$	$+82.42$	$+17$	$-6$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on `main`	$±Time$	Test Case
examples	💔	$0.01$	$+2.16$	example_add_facet_labels.Rd
shinytest2-tm_a_pca	💔	$0.02$	$+14.46$	e2e_tm_a_pca_Changing_output_encodings_for_plot_type_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+8.65$	e2e_tm_a_pca_Changing_output_encodings_of_NA_action_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+32.18$	e2e_tm_a_pca_Changing_output_encodings_of_font_size_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+32.32$	e2e_tm_a_pca_Changing_output_encodings_of_plot_type_hides_and_shows_options.
shinytest2-tm_a_pca	💔	$0.01$	$+13.82$	e2e_tm_a_pca_Changing_output_encodings_of_standardization_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+9.56$	e2e_tm_a_pca_Changing_output_encodings_of_tables_display_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+10.05$	e2e_tm_a_pca_Changing_output_encodings_of_theme_does_not_generate_errors.
shinytest2-tm_a_pca	💔	$0.01$	$+13.40$	e2e_tm_a_pca_Color_by_columns_data_extract_must_be_from_non_selected_variable_set.
shinytest2-tm_a_pca	💔	$0.01$	$+9.09$	e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_Assault_on_header.
shinytest2-tm_a_pca	💔	$0.01$	$+12.21$	e2e_tm_a_pca_Eigenvector_table_should_have_data_extract_selection_Murder_UrbanPop_on_header.
shinytest2-tm_a_pca	💔	$0.02$	$+9.55$	e2e_tm_a_pca_Module_is_initialised_with_the_specified_defaults_in_function_call.
shinytest2-tm_a_regression	💔	$0.01$	$+7.21$	e2e_tm_a_regression_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_response_and_regressor_arg.
shinytest2-tm_a_regression	💔	$0.03$	$+7.55$	e2e_tm_a_regression_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_a_regression	💔	$0.01$	$+11.70$	e2e_tm_a_regression_Outlier_definition_and_label_are_visible_by_default.
shinytest2-tm_a_regression	💔	$0.01$	$+7.64$	e2e_tm_a_regression_Outlier_definition_and_label_have_default_values_and_label_text.
shinytest2-tm_a_regression	💔	$0.01$	$+18.35$	e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_a_regression	💔	$0.01$	$+9.45$	e2e_tm_a_regression_Plot_type_is_set_properly.
shinytest2-tm_a_regression	💔	$0.02$	$+12.94$	e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition.
shinytest2-tm_data_table	💔	$0.01$	$+6.66$	e2e_tm_data_table_Initializes_without_errors
shinytest2-tm_data_table	💔	$0.01$	$+6.79$	e2e_tm_data_table_Verify_checkbox_displayed_over_data_table
shinytest2-tm_data_table	💔	$0.01$	$+7.72$	e2e_tm_data_table_Verify_default_variable_selection_and_set_new_selection
shinytest2-tm_data_table	💔	$0.01$	$+9.89$	e2e_tm_data_table_Verify_module_displays_data_table
shinytest2-tm_file_viewer	💔	$0.01$	$+7.05$	e2e_tm_file_viewer_Initializes_without_errors_and_shows_files_tree_specified_in_input_path_argument
shinytest2-tm_file_viewer	💔	$0.02$	$+9.22$	e2e_tm_file_viewer_Shows_selected_image_file
shinytest2-tm_file_viewer	💔	$0.01$	$+9.31$	e2e_tm_file_viewer_Shows_selected_text_file
shinytest2-tm_file_viewer	💔	$0.01$	$+9.12$	e2e_tm_file_viewer_Shows_selected_url
shinytest2-tm_front_page	💔	$0.01$	$+6.15$	e2e_tm_front_page_Initializes_without_errors_and_check_html_elements
shinytest2-tm_front_page	💔	$0.01$	$+11.20$	e2e_tm_front_page_Verify_the_module_displays_metadata
shinytest2-tm_front_page	💔	$0.01$	$+10.23$	e2e_tm_front_page_Verify_the_module_displays_tables
shinytest2-tm_g_bivariate	💔	$0.01$	$+21.82$	e2e_tm_g_bivariate_Coloring_options_are_hidden_when_coloring_is_toggled_off.
shinytest2-tm_g_bivariate	💔	$0.01$	$+25.77$	e2e_tm_g_bivariate_Facetting_options_are_hidden_when_facet_is_toggled_off.
shinytest2-tm_g_bivariate	💔	$0.01$	$+8.75$	e2e_tm_g_bivariate_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_bivariate	💔	$0.02$	$+38.64$	e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_g_distribution	💔	$0.01$	$+23.02$	e2e_tm_g_distribution_Histogram_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_distribution	💔	$0.01$	$+35.87$	e2e_tm_g_distribution_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_distribution	💔	$0.01$	$+13.74$	e2e_tm_g_distribution_QQ_plot_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response	💔	$0.02$	$+7.77$	e2e_tm_g_response_deselecting_response_produces_validation_error.
shinytest2-tm_g_response	💔	$0.01$	$+7.84$	e2e_tm_g_response_deselecting_x_produces_validation_error.
shinytest2-tm_g_response	💔	$0.01$	$+17.15$	e2e_tm_g_response_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_response	💔	$0.01$	$+7.95$	e2e_tm_g_response_module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot	💔	$0.01$	$+11.72$	e2e_tm_g_scatterplot_Base_for_the_log_transformation_can_be_applied.
shinytest2-tm_g_scatterplot	💔	$0.01$	$+9.64$	e2e_tm_g_scatterplot_Get_validation_error_when_facetting_with_the_same_row_col_variable.
shinytest2-tm_g_scatterplot	💔	$0.01$	$+8.40$	e2e_tm_g_scatterplot_Module_is_initialised_with_the_specified_defaults.
shinytest2-tm_g_scatterplot	👶		$+47.32$	e2e_tm_g_scatterplot_The_encoding_inputs_are_set_without_validation_errors.
shinytest2-tm_g_scatterplot	💀	$0.01$	$-0.01$	e2e_tm_g_scatterplot_The_encoding_inputs_produce_output_without_validation_errors.
shinytest2-tm_g_scatterplot	💔	$0.01$	$+12.28$	e2e_tm_g_scatterplot_The_log_transform_is_only_possible_for_positive_numeric_vars.
shinytest2-tm_g_scatterplotmatrix	💔	$0.01$	$+11.40$	e2e_tm_g_scatterplotmatrix_Change_plot_settings
shinytest2-tm_g_scatterplotmatrix	💔	$0.02$	$+7.69$	e2e_tm_g_scatterplotmatrix_Initializes_without_errors
shinytest2-tm_g_scatterplotmatrix	💔	$0.01$	$+9.12$	e2e_tm_g_scatterplotmatrix_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_g_scatterplotmatrix	💔	$0.01$	$+9.56$	e2e_tm_g_scatterplotmatrix_Verify_module_displays_data_table
shinytest2-tm_misssing_data	💔	$0.01$	$+16.35$	e2e_tm_missing_data_Check_default_settings_and_visibility_of_the_combinations_graph_and_encodings
shinytest2-tm_misssing_data	💔	$0.01$	$+17.26$	e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph
shinytest2-tm_misssing_data	💔	$0.01$	$+8.41$	e2e_tm_missing_data_Initializes_without_errors
shinytest2-tm_misssing_data	💔	$0.01$	$+10.47$	e2e_tm_missing_data_Validate_By_Variable_Levels_table_values
shinytest2-tm_misssing_data	💔	$0.01$	$+14.33$	e2e_tm_missing_data_Validate_functionality_and_UI_response_for_By_Variable_Levels_
shinytest2-tm_outliers	💔	$0.01$	$+15.17$	e2e_tm_outliers_Data_extract_spec_elements_are_initialized_with_the_default_values_specified_by_outlier_var_and_categorical_var_argument.
shinytest2-tm_outliers	💔	$0.01$	$+9.73$	e2e_tm_outliers_Data_parameter_and_module_label_is_passed_properly.
shinytest2-tm_outliers	💔	$0.01$	$+14.79$	e2e_tm_outliers_Default_radio_buttons_are_set_properly.
shinytest2-tm_outliers	💔	$0.01$	$+9.60$	e2e_tm_outliers_Method_parameters_are_set_properly.
shinytest2-tm_outliers	💔	$0.01$	$+10.06$	e2e_tm_outliers_Module_is_divided_into_3_tabs.
shinytest2-tm_outliers	💔	$0.01$	$+32.76$	e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method.
shinytest2-tm_outliers	💔	$0.01$	$+14.46$	e2e_tm_outliers_Outlier_table_is_displayed_with_proper_content.
shinytest2-tm_outliers	💔	$0.01$	$+17.05$	e2e_tm_outliers_Outliers_summary_table_is_displayed_with_proper_content.
shinytest2-tm_outliers	💔	$0.01$	$+12.57$	e2e_tm_outliers_Plot_type_is_correctly_set_by_default_and_has_appropriate_possible_options.
shinytest2-tm_outliers	💔	$0.01$	$+22.06$	e2e_tm_outliers_Plot_type_is_hidden_when_Boxplot_tab_is_not_selected.
shinytest2-tm_t_crosstable	💔	$0.01$	$+12.90$	e2e_tm_t_crosstable_Change_plot_settings
shinytest2-tm_t_crosstable	💔	$0.01$	$+8.21$	e2e_tm_t_crosstable_Initializes_without_errors
shinytest2-tm_t_crosstable	💔	$0.01$	$+10.60$	e2e_tm_t_crosstable_Verify_default_values_and_settings_data_extracts_for_data_selection
shinytest2-tm_t_crosstable	💔	$0.01$	$+9.70$	e2e_tm_t_crosstable_Verify_module_displays_data_table
shinytest2-tm_variable_browser	💔	$0.01$	$+12.48$	e2e_tm_variable_browser_Selecting_treat_variable_as_factor_changes_the_table_headers.
shinytest2-tm_variable_browser	💔	$0.01$	$+14.52$	e2e_tm_variable_browser_changing_display_density_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser	💔	$0.01$	$+15.96$	e2e_tm_variable_browser_changing_outlier_definition_encoding_doesn_t_show_errors.
shinytest2-tm_variable_browser	💔	$0.01$	$+17.32$	e2e_tm_variable_browser_changing_plot_setting_encodings_doesn_t_show_errors.
shinytest2-tm_variable_browser	💔	$0.01$	$+11.37$	e2e_tm_variable_browser_content_is_displayed_correctly.
shinytest2-tm_variable_browser	💔	$0.01$	$+10.77$	e2e_tm_variable_browser_selection_of_categorical_variable_has_a_table_with_level_header.

Results for commit 777f843

♻️ This comment has been updated with latest results.

DESCRIPTION

Co-authored-by: Vedha Viyash <[email protected]> Signed-off-by: Dawid Kałędkowski <[email protected]>

…esolved #925

Please check also: - insightsengineering/teal.modules.general#927 - Removed `$active_` methods in favour of one `$namespaces()` - `namespaces(FALSE)` (default) gives a list of `ns` functions, so that: - `namespaces(FALSE)$module("element-id-in-module")` will return an id of element - `namespaces(TRUE)$module("element-id-in-module")` will return an id of element prefixed by `#` - `namespaces()` returns following namespaces: `module`, `filter_panel`, `data_summary`, `wrapper` --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Vedha Viyash <[email protected]>

changed TealAppDriver constructor

5cf06aa

gogonzo added the core label Oct 10, 2025

m7pr self-requested a review October 10, 2025 12:10

m7pr self-assigned this Oct 10, 2025

m7pr approved these changes Oct 10, 2025

View reviewed changes

gogonzo and others added 2 commits October 14, 2025 11:10

clean checks

0d2c867

[skip style] [skip vbump] Restyle files

c32781d

gogonzo mentioned this pull request Oct 14, 2025

Teal app driver changes insightsengineering/teal#1633

Merged

empty

0303038

gogonzo and others added 3 commits October 14, 2025 14:56

link teal branch

00811bc

Merge branch 'main' into TealAppDriver_changes

c61f6ce

fix: update outlier test assertion

541d2a0

vedhav reviewed Oct 15, 2025

View reviewed changes

DESCRIPTION Outdated Show resolved Hide resolved

gogonzo and others added 2 commits October 15, 2025 15:38

Update DESCRIPTION

f1defb8

Co-authored-by: Vedha Viyash <[email protected]> Signed-off-by: Dawid Kałędkowski <[email protected]>

chore: skip the association plot tests until the ggmosaic issue is r…

7a8e0d7

…esolved #925

vedhav merged commit ffbf5d4 into main Oct 15, 2025
52 of 53 checks passed

vedhav deleted the TealAppDriver_changes branch October 15, 2025 16:53

github-actions bot locked and limited conversation to collaborators Oct 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

changed TealAppDriver constructor #927

changed TealAppDriver constructor #927

Uh oh!

gogonzo commented Oct 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 10, 2025 •

edited

Loading

Uh oh!

m7pr commented Oct 10, 2025

Uh oh!

m7pr left a comment

Uh oh!

m7pr commented Oct 10, 2025

Uh oh!

gogonzo commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 14, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

changed TealAppDriver constructor #927

changed TealAppDriver constructor #927

Uh oh!

Conversation

gogonzo commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Tests Summary

Uh oh!

github-actions bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Diff against main

Uh oh!

m7pr commented Oct 10, 2025

Uh oh!

m7pr left a comment

Choose a reason for hiding this comment

Uh oh!

m7pr commented Oct 10, 2025

Uh oh!

gogonzo commented Oct 10, 2025

Uh oh!

github-actions bot commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unit Test Performance Difference

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gogonzo commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 10, 2025 •

edited

Loading

github-actions bot commented Oct 14, 2025 •

edited

Loading