-
-
Notifications
You must be signed in to change notification settings - Fork 49
Teal app driver changes #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teal app driver changes #1633
Conversation
Code Coverage SummaryDiff against mainResults for commit: d422b35 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 25 suites 2m 17s ⏱️ Results for commit d422b35. ♻️ This comment has been updated with latest results. |
Unit Test Performance Difference
Results for commit c5b5e92 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Let's wait for the tmg and tmc PRs to be approved before merging.
|
@vedhav just double checking, the expectation is that you will approve tmg and tmc right? |
|
@m7pr Yes, tmc will be approved shortly. tmg has 5 failing tests, I just fixed one. Once the rest is fixed I will approve and we merge all of them together |
|
Thanks, you are the legend! |
Please check also:
changed TealAppDriver constructor teal.modules.general#927
Removed
$active_methods in favour of one$namespaces()namespaces(FALSE)(default) gives a list ofnsfunctions, so that:-
namespaces(FALSE)$module("element-id-in-module")will return an id of element-
namespaces(TRUE)$module("element-id-in-module")will return an id of element prefixed by#-
namespaces()returns following namespaces:module,filter_panel,data_summary,wrapper