Skip to content

Conversation

@gogonzo
Copy link
Contributor

@gogonzo gogonzo commented Oct 13, 2025

Please check also:

  • changed TealAppDriver constructor teal.modules.general#927

  • Removed $active_ methods in favour of one $namespaces()

  • namespaces(FALSE) (default) gives a list of ns functions, so that:
    - namespaces(FALSE)$module("element-id-in-module") will return an id of element
    - namespaces(TRUE)$module("element-id-in-module") will return an id of element prefixed by #
    - namespaces() returns following namespaces: module, filter_panel, data_summary, wrapper

@vedhav vedhav self-assigned this Oct 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

badge

Code Coverage Summary

Filename                          Stmts    Miss  Cover    Missing
------------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------
R/after.R                            63      63  0.00%    15-89
R/checkmate.R                        24       0  100.00%
R/dummy_functions.R                  61       2  96.72%   44, 46
R/include_css_js.R                   11       0  100.00%
R/init.R                            152       1  99.34%   299
R/landing_popup_module.R             34      10  70.59%   44-53
R/module_bookmark_manager.R         153     117  23.53%   54-58, 78-133, 138-139, 151, 198, 233-310
R/module_data_summary.R             177       8  95.48%   40, 50, 205, 236-240
R/module_filter_data.R               64       0  100.00%
R/module_filter_manager.R           229      50  78.17%   72-81, 89-94, 107-111, 116-117, 290-313, 339, 366, 378, 385-386
R/module_init_data.R                 84       6  92.86%   38-43
R/module_nested_tabs.R              371      37  90.03%   163, 267-282, 302-306, 324, 361, 479-482, 486-489, 493-496, 541
R/module_session_info.R              18       0  100.00%
R/module_snapshot_manager.R         271     194  28.41%   103-112, 120-144, 163-164, 181-210, 214-229, 231-238, 245-275, 279, 283-287, 289-295, 298-311, 314-322, 352-366, 369-380, 383-397, 410
R/module_source_code.R               69       7  89.86%   54, 58, 107-111
R/module_teal_data.R                149      76  48.99%   43-149
R/module_teal_lockfile.R            131      53  59.54%   45-57, 60-62, 76, 86-88, 100-102, 110-119, 122, 124, 126-127, 142-146, 161-162, 177-186
R/module_teal_reporter.R            116      16  86.21%   60, 77-78, 81, 98, 127, 141, 143, 155, 157, 159, 204-208
R/module_teal_with_splash.R          33      33  0.00%    24-61
R/module_teal.R                     213      28  86.85%   130, 134-135, 145-146, 186, 204-220, 222, 255-256, 263-264
R/module_transform_data.R           116       6  94.83%   46, 130-134
R/modules.R                         291      51  82.47%   170-174, 229-232, 356-376, 384, 390, 567-573, 586-594, 609-624
R/reporter_previewer_module.R        41      41  0.00%    22-85
R/show_rcode_modal.R                 31      31  0.00%    17-49
R/tdata.R                            14      14  0.00%    19-61
R/teal_data_module-eval_code.R       23       0  100.00%
R/teal_data_module-within.R           7       0  100.00%
R/teal_data_module.R                 20       0  100.00%
R/teal_data_utils.R                  49       0  100.00%
R/teal_modifiers.R                   57       0  100.00%
R/teal_slices-store.R                29       0  100.00%
R/teal_slices.R                      63       0  100.00%
R/teal_transform_module.R            45       0  100.00%
R/TealAppDriver.R                   297     297  0.00%    50-620
R/utils.R                           291      48  83.51%   402-451, 539-548
R/validate_inputs.R                  32       0  100.00%
R/validations.R                      58      37  36.21%   114-392
R/zzz.R                              19      15  21.05%   4-22
TOTAL                              3906    1241  68.23%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  --------
R/TealAppDriver.R      -46     -46  +100.00%
TOTAL                  -46     -46  +0.79%

Results for commit: d422b35

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Unit Tests Summary

  1 files   25 suites   2m 17s ⏱️
305 tests 255 ✅ 50 💤 0 ❌
510 runs  458 ✅ 52 💤 0 ❌

Results for commit d422b35.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
module_teal 💔 $108.66$ $+3.15$ $0$ $0$ $0$ $0$

Results for commit c5b5e92

♻️ This comment has been updated with latest results.

Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's wait for the tmg and tmc PRs to be approved before merging.

@m7pr
Copy link
Contributor

m7pr commented Oct 15, 2025

@vedhav just double checking, the expectation is that you will approve tmg and tmc right?

@vedhav
Copy link
Contributor

vedhav commented Oct 15, 2025

@m7pr Yes, tmc will be approved shortly. tmg has 5 failing tests, I just fixed one. Once the rest is fixed I will approve and we merge all of them together

@m7pr
Copy link
Contributor

m7pr commented Oct 15, 2025

Thanks, you are the legend!

@gogonzo gogonzo enabled auto-merge (squash) October 15, 2025 13:47
@gogonzo gogonzo disabled auto-merge October 15, 2025 14:07
@gogonzo gogonzo merged commit 09e3858 into main Oct 15, 2025
28 checks passed
@gogonzo gogonzo deleted the TealAppDriver_changes branch October 15, 2025 15:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants