-
-
Notifications
You must be signed in to change notification settings - Fork 50
📑 Reporter Refactor: Adds support for new teal_report and teal_card class
#1541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # R/module_nested_tabs.R # R/module_teal.R # R/module_transform_data.R
# Conflicts: # R/module_nested_tabs.R
# Conflicts: # DESCRIPTION # R/module_data_summary.R # R/module_nested_tabs.R # R/module_teal.R # R/module_transform_data.R
# Conflicts: # R/module_teal.R
Hey @vedhav @gogonzo just letting you know that I am merging `main` into `test@bslib@main` branch, so that on other repositories, like `tmg`, we can install `teal` from this branch and also we can satisfy condition for `teal` to be `>= 0.16.0`. https://github.com/insightsengineering/teal.modules.general/blob/report_redesign_poc%40main/DESCRIPTION#L83 https://github.com/insightsengineering/teal.modules.general/blob/report_redesign_poc%40main/DESCRIPTION#L30 --------- Co-authored-by: Dony Unardi <[email protected]> Co-authored-by: insights-engineering-bot <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I fixed tests, but I left 2 comments.
We also postponed one TODO and made an issue for that to handle at some point:
#1588
Signed-off-by: Marcin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this. The next follow-up is created in this issue #1588
…orter UI (#331) # Pull Request Fixes: - insightsengineering/teal#1526 Built on top of: - #307 - _(#307 will be closed once this PR is stable)_ ### Companion PRs: - insightsengineering/teal#1541 - insightsengineering/teal.code#255 - insightsengineering/teal.data#370 - #331 - insightsengineering/teal.modules.general#884 - insightsengineering/teal.modules.clinical#1392 ### Changes description - Adds new object called `teal_report` that extends `teal_data` - The card/report for a module is built automatically with `eval_code()` and `eval_code(cache = TRUE)` - (adding code and print objects respectively) - Report slot can be manipulated with `report(<teal_report>)` - Rename of `report_document` to `doc`/`document`/`page` (final name TBD) --------- Signed-off-by: Marcin <[email protected]> Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: m7pr <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dawid Kaledkowski <[email protected]> Co-authored-by: Marcin <[email protected]> Co-authored-by: vedhav <[email protected]> Co-authored-by: Lluís Revilla <[email protected]> Co-authored-by: Pawel Rucki <[email protected]>
Pull Request
Built on top of:
teal.reporterCards #1499 (will be closed once this PR is stable)Companion PRs:
teal_reportandteal_cardclass #1541{teal}module returns ateal_reportobject that extends fromteal_datateal.code#255{teal}module returns ateal_reportobject that extends fromteal_datateal.data#370teal_report,teal_cardclass and revamps reporter UI teal.reporter#331teal_reportandteal_cardclass teal.modules.general#884Changes description
teal_reportobject is returned from the modulemodify_reactive_output()toafter()Sample app