ci: Fix e2e job failures #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
booxter
commented
May 20, 2025
booxter
commented
- fix: Require medium and large E2E jobs to use constraints-dev.txt to unblock jobs
- ci: Install flash-attn using the same torch version before reqs
…unblock jobs In the core repo, we are using constraints-dev.txt to constrain our dependencies in the CI: https://github.com/instructlab/instructlab/blob/main/.github/workflows/e2e-nvidia-l40s-x4.yml#L175 In this repo, we are pulling the E2E workflow from the core repo without actually passing in `-c constraints-dev.txt` Signed-off-by: Courtney Pacheco <[email protected]>
This should help with failures due to mixed C bindings symbols we see in CI. This is modeled from: instructlab/instructlab#3399 In the future, the repo should adopt `scripts/install-ilab-with-cuda.sh` from ilab repo to avoid duplication. Signed-off-by: Ihar Hrachyshka <[email protected]>
Contributor
Author
|
As @courtneypacheco correctly points out, this change applies to pull_request_target workflow, meaning it won't be tested in the currently running CI. To test it, we would have to push the branch to main repo, then manually start a workflow of interest using this branch. I don't have write access to the repo, so I can't do it even if I wanted. Besides, I think it's crucial that eval folks are involved in fixing the CI for the repo. I am an outsider and can only guide. |
Contributor
Author
|
@instructlab/eval-maintainers please take a look at this and see to test this or some other fix for CI. AFAIU the eval CI is broken for a month at least, it's time to get this fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.