Conversation
Signed-off-by: klawrenc <klawrenc@redhat.com>
github-actions
bot
added
triage-needed
|
Beep, boop 🤖, Hi, I'm @instructlab-bot and I'm going to help you with your pull request. Thanks for you contribution! 🎉 I support the following commands:
Note Results or Errors of these commands will be posted as a pull request check in the Checks section below Note Currently only maintainers belongs to [[taxonomy-triagers taxonomy-approvers taxonomy-maintainers instructlab-bot-triagers instructlab-bot-maintainers oversight-committee]] teams are allowed to run these commands. |
nimbinatus
left a comment
nimbinatus
left a comment
There was a problem hiding this comment.
Hi there! Thanks for submitting some knowledge! Unfortunately, there are some things that need to get fixed before we can accept this proposal. I've left some notes; please let me know if you have any questions. You can reply here, or you can find the taxonomy maintainers (including me!) on Slack or Discord to chat about this.
| @@ -0,0 +1,5 @@ | |||
| Title of work: History of films | |||
| Link to work: https://www.blackwellpublishing.com/content/BPL_Images/Content_store/ThumbNail/BURGOYNE9781405146029/9781405146029.pdf | |||
There was a problem hiding this comment.
Unfortunately, we cannot accept this source due to licensing restrictions. To keep InstructLab open source, we have to vet all sources to ensure they are also open source. To learn more, read our current licensing limitations for sources and list of accepted sources.
| @@ -0,0 +1,5 @@ | |||
| Title of work: History of films | |||
| Link to work: https://www.blackwellpublishing.com/content/BPL_Images/Content_store/ThumbNail/BURGOYNE9781405146029/9781405146029.pdf | |||
| Revision: https://en.wikipedia.org/wiki/History_of_film_technology | |||
There was a problem hiding this comment.
The revision field should be a pointer to a specific version of the link to work URL, such as the versioned link of a Wikipedia document. So, if this link was the link to work (the reference), the revision field might have https://en.wikipedia.org/w/index.php?title=History_of_film_technology&oldid=1262139683, which can be found from the Tools dropdown in the upper right of a Wikipedia page as the Permanent Link.
If the source material does not have versioning, then it does not need to have this field.
There was a problem hiding this comment.
Note that, if you're using multiple sources, you would use multiple link to work fields, as in this example: https://github.com/instructlab/taxonomy/blob/38e3e3e88e3fd5acdbf32fd19fa5ae81178c9379/compositional_skills/grounded/linguistics/inclusion/attribution.txt
| Title of work: History of films | ||
| Link to work: https://www.blackwellpublishing.com/content/BPL_Images/Content_store/ThumbNail/BURGOYNE9781405146029/9781405146029.pdf | ||
| Revision: https://en.wikipedia.org/wiki/History_of_film_technology | ||
| License of the work: 12455 |
There was a problem hiding this comment.
The license here should be a publishing license. Examples include Creative Commons licenses (note that many Wikipedia pages often use a Creative Commons license called CC BY-SA), public domain (no license, really), and copyright. What does 12455 here signify?
| reference for films over the years, how it was made and the general history of | ||
| cinema | ||
| seed_examples: | ||
| - context: This model is a resource for the history of film |
There was a problem hiding this comment.
The context field should be content from the source document referenced in the attribution file. The content you pull from that document for this field should include enough information for a random reader to answer the questions you pose in the questions_and_answers section, as if someone is reading for a test. Note that the context field can have up to 500 words.
All of these context fields need more information, and it needs to come from a source document.
There was a problem hiding this comment.
Also, for reference, the model will not answer exactly as you have in the seed examples. It may use different wording or phrases and may structure answers differently. The data, though, will always be the same. So don't worry about exact answer wording.
| seed_examples: | ||
| - context: This model is a resource for the history of film | ||
| questions_and_answers: | ||
| - question: who won the Oscar for leading man in a film in 1980 |
There was a problem hiding this comment.
| - question: who won the Oscar for leading man in a film in 1980 | |
| - question: Who won the Oscar for leading man in a film in 1980? |
For all of these, please use punctuation at the end.
nimbinatus
added
triage-requested-changes
|
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
|
not stale
|
|
This pull request has been automatically marked as stale because it has not had activity within 15 days. It will be automatically closed if no further activity occurs within the next 31 days. |
2 participants
reference for films over the years, how it was made and the general history of cinema