Merged
Conversation
mergify
bot
added
testing
Dolomite has become a legacy performance and compatibility dependency required before Granite was upstreamed to Huggingface. For >=python3.12, Dolomite has been found to not work correctly. Therefore, we're dropping support. Signed-off-by: James Kunstle <jkunstle@redhat.com> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
booxter
added a commit
to booxter/instructlab
that referenced
this pull request
Jun 18, 2025
It's being removed in training library. See: instructlab/training#616 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
6 tasks
|
E2E (NVIDIA L40S x4) (python 3.11) workflow launched on this PR: View run |
Closed
|
e2e workflow succeeded on this PR: View run, congrats! |
fynnsu
approved these changes
Jun 20, 2025
Collaborator
fynnsu
left a comment
fynnsu
left a comment
There was a problem hiding this comment.
LGTM! I noticed dolomite is still in the constraints-dev.txt but presumably that
- doesn't matter
- will get cleared in the next update of
constraints-dev.txt
Contributor
Author
|
Yep I didn't want to touch constraints file because indeed it doesn't matter, will be cleaned up AND it lowers the chance of git conflict. Also, it's nice when robots do the work. |
mergify bot
added a commit
to instructlab/instructlab
that referenced
this pull request
Jun 20, 2025
It's being removed in training library. See: instructlab/training#616 Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com> **Checklist:** - [ ] **Commit Message Formatting**: Commit titles and messages follow guidelines in the [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/#summary). - [ ] [Changelog](https://github.com/instructlab/instructlab/blob/main/CHANGELOG.md) updated with breaking and/or notable changes for the next minor release. - [ ] Documentation has been updated, if necessary. - [ ] Unit tests have been added, if necessary. - [ ] Functional tests have been added, if necessary. - [ ] E2E Workflow tests have been added, if necessary. Approved-by: RobotSail Approved-by: nathan-weinberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dolomite has become a legacy performance and compatibility dependency
required before Granite was upstreamed to Huggingface. For >=python3.12,
Dolomite has been found to not work correctly. Therefore, we're dropping
support.
Signed-off-by: James Kunstle jkunstle@redhat.com
Signed-off-by: Ihar Hrachyshka ihar.hrachyshka@gmail.com