Fix old theme override #2301
Merged
Fix old theme override #2301
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyasf
force-pushed
the
fix_old_themeOverride
branch
from
28a5e89 to
8a023ce
Compare
|
Contributor
|
On the Using theme overrides page: |
Contributor
|
On the Using theme overrides page: Changing ic-link-color changes the color of 'normal link' too in v11 |
ToMESSKa
requested changes
Dec 10, 2025
Contributor
ToMESSKa
left a comment
ToMESSKa
left a comment
There was a problem hiding this comment.
I found some overrides work differently in v11, see them above
to test:
this code should render a button with fully
rounded corners
```
<Button
themeOverride={{borderRadius: '100px'}}
>sdfdsf</Button>
```
check theme override pages in the docs
matyasf
force-pushed
the
fix_old_themeOverride
branch
from
8a023ce to
2fbb5ca
Compare
Collaborator
Author
This is because the token has changed in |
Collaborator
Author
This is because brand theme variables are not working yet in reworked components. |
ToMESSKa
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue came up because we refactored
getComponentThemeOverrideto test:
this code should render a button with fully
rounded corners
check theme override pages in the docs