Skip to content

Fix old theme override #2301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matyasf merged 1 commit into from
Dec 11, 2025
Merged

Fix old theme override #2301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docs/guides/using-theme-overrides.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,14 +227,17 @@ type: example

<div>
<Button color='primary'
themeOverride={{ primaryBackground: "purple" }}
themeOverride={{
primaryBackground: "purple",
borderRadius: '999rem'
}}
margin="small 0 large">
Purple Primary Button
Purple Primary Button with rounded corners
</Button>
<InstUISettingsProvider
theme={{
componentOverrides: {
TextInput: { background: "yellow" }
TextInput: { backgroundColor: "yellow" }
}
}}
>
Expand Down
2 changes: 1 addition & 1 deletion packages/emotion/src/withStyle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ const withStyle = decorator(
theme,
displayName,
ComposedComponent.componentId,
(componentProps as any).themeOverride,
(componentProps as ThemeOverrideProp).themeOverride,
baseComponentTheme
)

Expand Down
2 changes: 1 addition & 1 deletion packages/emotion/src/withStyleRework.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ const withStyleRework = decorator(
theme,
displayName,
ComposedComponent.componentId,
componentProps,
(componentProps as ThemeOverrideProp).themeOverride,
componentTheme
)

Expand Down
Loading