-
Notifications
You must be signed in to change notification settings - Fork 1
Apps/roadmap/debounce #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves consistency in null/undefined handling and adds debouncing logic for the loading state. The changes standardize the use of null instead of undefined for initial state values and promise variables, and adds a 1-second delay before showing the loading indicator.
Key changes:
- Standardizes null/undefined usage across state variables and cached values
- Adds debounce behavior to prevent loading indicator from flashing immediately
- Version bump from 1.0.3 to 1.0.4
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/roadmap/src/utils/getRoadmap.ts | Updates null checking logic for cached roadmap and changes roadmapPromise assignment from undefined to null |
| apps/roadmap/src/App.tsx | Standardizes initial state values to use null and adds setShowLoading(false) call before debounce timeout |
| apps/roadmap/package.json | Version bump to 1.0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
No description provided.