Skip to content

Apps/roadmap/debounce #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thedannywahl merged 7 commits into from
Dec 2, 2025
Merged

Apps/roadmap/debounce #182

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
809898f
fix type assertion for roadmap
thedannywahl Dec 2, 2025
3000a27
[email protected]
thedannywahl Dec 2, 2025
4e56df6
instantiate correct types
thedannywahl Dec 2, 2025
284d999
simplify loading state
thedannywahl Dec 2, 2025
f2691d9
Merge branch 'main' into apps/roadmap/debounce
thedannywahl Dec 2, 2025
56b0eb7
update deps
thedannywahl Dec 2, 2025
e5da381
bind this to methods
thedannywahl Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/roadmap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@
"typecheck": "tsgo --noEmit"
},
"type": "module",
"version": "1.0.3"
}
"version": "1.0.4"
}
5 changes: 3 additions & 2 deletions apps/roadmap/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ import "./App.css";
const App: FC = () => {
const [overlayOpen, setOverlayOpen] = useState(false);
const [selectedEntry, setSelectedEntry] = useState<PendoAPIFeature | null>(
undefined,
null,
);
const [brandConfig, setBrandConfig] = useState<unknown>({});
const [roadmap, setRoadmap] = useState<RoadmapFeatures | null>(undefined);
const [roadmap, setRoadmap] = useState<RoadmapFeatures | null>(null);
const [isDark, setIsDark] = useState(false);

useEffect(() => {
Expand Down Expand Up @@ -76,6 +76,7 @@ const App: FC = () => {
const [showLoading, setShowLoading] = useState(false);
useEffect(() => {
if (!roadmap) {
setShowLoading(false);
const timeout = setTimeout(() => setShowLoading(true), 1000);
return () => clearTimeout(timeout);
} else {
Expand Down
4 changes: 2 additions & 2 deletions apps/roadmap/src/utils/getRoadmap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ type RoadmapRequestEvent = MessageEvent<{ value?: string }>;

const getRoadmap = (): Promise<RoadmapFeatures | null> => {
console.debug("getRoadmap called");
if (cachedRoadmap !== null) {
if (cachedRoadmap) {
console.debug("Returning cached roadmap");
return Promise.resolve(cachedRoadmap);
}
Expand All @@ -29,7 +29,7 @@ const getRoadmap = (): Promise<RoadmapFeatures | null> => {
window.removeEventListener("message", handler);
const result = paramsToPendo(event.data.value);
cachedRoadmap = result;
roadmapPromise = undefined;
roadmapPromise = null;
resolve(result);
}
// Ignore unrelated events
Expand Down