Implement best-effort resolution of arguments to unresolved invocables #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fourls
requested changes
May 6, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
Since name resolution issues are now much better hidden, should there be a debug-level log message when a name fails to be resolved?
cirras
force-pushed
the
best_effort_argument_resolution
branch
from
60ca97f to
3e19f48
Compare
cirras
force-pushed
the
best_effort_argument_resolution
branch
3 times, most recently
from
023c1f0 to
b337028
Compare
Property specifiers `read`/`write`/`implements`/`stored` were being resolved twice, which was unnecessary because they should be resolved as part of the top-level resolution of the `PropertyNode`. In a funny twist, it turns out we were actually relying on that second visit to resolve non-invocable expressions in `read`/`write`/`stored` specifiers. This is now handled properly in the top-level resolve.
cirras
force-pushed
the
best_effort_argument_resolution
branch
from
63217c9 to
3b86db8
Compare
fourls
requested changes
May 8, 2025
Collaborator
fourls
left a comment
fourls
left a comment
There was a problem hiding this comment.
This looks really good and will be a particularly helpful addition. The name resolution logging is also a great debugging improvement.
I have a couple of minor comments:
...hi-checks/src/test/java/au/com/integradev/delphi/checks/VariableInitializationCheckTest.java
Show resolved
Hide resolved
delphi-frontend/src/test/resources/au/com/integradev/delphi/symbol/typeResolution/Pointers.pas
Outdated
Show resolved
Hide resolved
These failures weren't important to the tests, but it's best for this code to be as well-formed as possible. Plus, it helped in identifying cases where we were logging name resolution failures erroneously.
This test was low-value and full of name resolution failures. The testing surface for simple symbol resolution is well-covered by the other 148 tests in this suite.
Delphi allows unresolved bare inherited expressions, and even generates them in event handlers. Logging them would be useless noise.
cirras
force-pushed
the
best_effort_argument_resolution
branch
from
3b86db8 to
e34166f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements best-effort name resolution for arguments in cases where the associated invocable could not be resolved.
It improves analysis quality in cases where symbol information is incomplete (whether due to misconfiguration or analyzer flaw).