🐛 Fix size_t handling in lookup::input
#649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - `lookup::input` takes an `auto` template parameter. - Platform-specific definitions of `std::size_t` make it awkward to ensure instantiations of `lookup::input` with the same size are in fact the same type. Solution: - fix the type of the `lookup::input` template parameter to `std::size_t`
lukevalenty
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
lookup::inputtakes anautotemplate parameter.std::size_tmake it awkward to ensure instantiations oflookup::inputwith the same size are in fact the same type.Solution:
lookup::inputtemplate parameter tostd::size_t