Skip to content

🐛 Fix size_t handling in lookup::input #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2024
Merged

🐛 Fix size_t handling in lookup::input #649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/lookup/input.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#include <type_traits>

namespace lookup {
template <typename K, typename V = K, auto N = 0ul> struct input {
template <typename K, typename V = K, std::size_t N = 0> struct input {
using key_type = K;
using value_type = V;

Expand Down
12 changes: 6 additions & 6 deletions test/lookup/input.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,22 @@ TEST_CASE("an input with no entries (type deduced)", "[input]") {
constexpr auto input = lookup::input{1};
CHECK(input.default_value == 1);
static_assert(
std::is_same_v<decltype(input), lookup::input<int, int, 0ul> const>);
CHECK(std::size(input) == 0ul);
std::is_same_v<decltype(input), lookup::input<int, int, 0> const>);
CHECK(std::size(input) == 0);
}

TEST_CASE("an input with no entries (explicit types)", "[input]") {
constexpr auto input = lookup::input<float, int>{1};
CHECK(input.default_value == 1);
static_assert(
std::is_same_v<decltype(input), lookup::input<float, int, 0ul> const>);
CHECK(std::size(input) == 0ul);
std::is_same_v<decltype(input), lookup::input<float, int, 0> const>);
CHECK(std::size(input) == 0);
}

TEST_CASE("an input with some entries (type deduced)", "[input]") {
constexpr auto input = lookup::input(1, std::array{lookup::entry{1.0f, 2}});
CHECK(input.default_value == 1);
static_assert(
std::is_same_v<decltype(input), lookup::input<float, int, 1ul> const>);
CHECK(std::size(input) == 1ul);
std::is_same_v<decltype(input), lookup::input<float, int, 1> const>);
CHECK(std::size(input) == 1);
}