fix: missing CVEs by switching to cve 2.0 (#5172) #5265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I won't be available for comments/replies/changes until later this month. Sorry in advance for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most CVE prior to 2018 are missing from cve 1.1 data, and this can be very problematic when retrieving CVEs for older software.
Issue #5172 seemed stale, so I went on fix it. CVE 2.0 parsing/formatting was already implemented for
api2NVD data retrieval (although the latter seems broken now for an unrelated reason: 403 forbidden ondashboard/statistics. This is out of scope for this PR). Therefore, it looks like minimal changes were required to make the switch. Namely, checking for "rejected" CVE didn't work with any rejected CVEs I've seen so far, so I used what seemed to be the proper field to check.Updated tests in this PR seem to run fine with
LONG_TESTS=1andEXTERNAL_SYSTEM=1.I'm not sure about: