-
Notifications
You must be signed in to change notification settings - Fork 76
Set FastMathFlags by default
#2480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3f4acb1 to
e5996c5
Compare
Signed-off-by: Whitney Tsang <[email protected]>
e5996c5 to
831d42b
Compare
|
Should be the fast math controlled by the user for tuning the accuracy? |
According to the logic in triton-lang/triton@84fe9da, users are expected to use libdevice if they want high precision. |
Make sense. Another question not related to this PR. It seems the default path has already uses the fast math because we use the same lowering logic as the upstream. Is it? |
Default path uses the same lowering logic as upstream, but it doesn't add fast math as aggressive as this PR. This PR adds to add possible operations that have the fast math interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to see something to evidence that this change makes a difference (like some tests) but the changes look fine.
Signed-off-by: Whitney Tsang <[email protected]>
Move setting of fast math flags from
ScheduleLoadpass, so that it can be reused for both default and advanced path.CI: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/11302770929