Use the same driver for the upstream profiler as for the legacy profiler with IPEX #2510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler with IPEX Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Oct 18, 2024
| from .benchmark_testing import do_bench, assert_close, perf_report, Benchmark, USE_IPEX_OPTION, BENCHMARKING_METHOD # type: ignore # noqa: F401 | ||
|
|
||
| if USE_IPEX_OPTION: | ||
| if USE_IPEX_OPTION or BENCHMARKING_METHOD == "UPSTREAM_PYTORCH_PROFILER": |
Contributor
Author
There was a problem hiding this comment.
For elapsed_time I still want to leave the upstream driver, since it does not contain additional function calls for profiling, which introduce their overhead, but will not be used, since there is a different profiling technology.
chengjunlu
approved these changes
Oct 21, 2024
anmyachev
added a commit
that referenced
this pull request
Dec 17, 2024
The same way as for Triton benchmarks, let's see how it works. Ref: #2510 https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/12379668850 (upstream profiler) Signed-off-by: Anatoly Myachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another preparatory step to switching to an upstream profiler.
Closes #2512