Skip to content

Conversation

@etiotto
Copy link
Contributor

@etiotto etiotto commented Oct 28, 2024

No description provided.

etiotto added 30 commits October 9, 2024 16:43
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
Signed-off-by: Tiotto, Ettore <[email protected]>
@etiotto
Copy link
Contributor Author

etiotto commented Oct 30, 2024

Depends on PR #2598

@etiotto
Copy link
Contributor Author

etiotto commented Oct 31, 2024

@etiotto etiotto requested a review from chengjunlu October 31, 2024 15:35
@etiotto
Copy link
Contributor Author

etiotto commented Nov 1, 2024

Depends on PR #2598

I have merged that PR in now.

@etiotto etiotto marked this pull request as ready for review November 1, 2024 17:08
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why all changes not in compiler.py are needed?

@etiotto
Copy link
Contributor Author

etiotto commented Nov 4, 2024

Can you please explain why all changes not in compiler.py are needed?

You want some comments in the PR to help understand what each change does ? Can you be more specific and put comments on pieces of code you want explained? I'll start to add comments only in the major pieces.

@whitneywhtsang
Copy link
Contributor

Can you please explain why all changes not in compiler.py are needed?

You want some comments in the PR to help understand what each change does ? Can you be more specific and put comments on pieces of code you want explained? I'll start to add comments only in the major pieces.

Discussed offline, one main change is to use intel version of ModuleAxisInfoAnalysis.

@etiotto
Copy link
Contributor Author

etiotto commented Nov 4, 2024

Depends on PR @#2623.

@etiotto etiotto merged commit 5b94131 into main Nov 5, 2024
5 checks passed
@etiotto etiotto deleted the etiotto.remove_rewrite_tensor_ptr branch November 5, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the RewriteTensorPointer pass

4 participants