Update integer literals for PyArg_ParseTuple
#2938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Dec 5, 2024
anmyachev
commented
Dec 5, 2024
| "int32_t": "i", | ||
| "int64_t": "l", | ||
| "int32_t": "l", | ||
| "int64_t": "L", |
Contributor
Author
There was a problem hiding this comment.
From python docs:
L ([int](https://docs.python.org/3/library/functions.html#int)) [long long]
Convert a Python integer to a C long long.L ~ long long int at least 64 bits
Signed-off-by: Anatoly Myachev <[email protected]>
anmyachev
commented
Dec 5, 2024
| "int16_t": "h", | ||
| "int32_t": "i", | ||
| "int64_t": "l", | ||
| "int64_t": "L", |
Contributor
Author
There was a problem hiding this comment.
Corresponding change in the upstream: triton-lang/triton@390e27f
whitneywhtsang
approved these changes
Dec 5, 2024
Contributor
|
Oh I thought you are going to directly upstream this change. |
Contributor
Author
The change for AMD is already in Triton upstream. I merged this pull request so that the change would also be for our file: |
Contributor
icic, it just got merged 1 hour ago upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test pull request before upstreaming.
The changes are based on https://docs.python.org/3/c-api/arg.html#numbers and https://en.cppreference.com/w/c/language/arithmetic_types