Skip to content

[CI][sglang] Fixed sglang testing, added pin, updated patch #5376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 24, 2025
Merged

[CI][sglang] Fixed sglang testing, added pin, updated patch #5376

merged 12 commits into from
Oct 24, 2025

Conversation

@Egor-Krivov
Copy link
Contributor

@Egor-Krivov Egor-Krivov commented Oct 23, 2025

  1. Adds sglang pin
  2. Updates patch, current patch is broken
  3. Unifies sglang testing with the rest of third-party testing

Closes #5375

@Egor-Krivov Egor-Krivov mentioned this pull request Oct 23, 2025
Merged
2 tasks
whitneywhtsang
whitneywhtsang approved these changes Oct 23, 2025
View reviewed changes
@Egor-Krivov Egor-Krivov enabled auto-merge (squash) October 24, 2025 10:51
@Egor-Krivov Egor-Krivov mentioned this pull request Oct 24, 2025
Merged
4 tasks
@Egor-Krivov Egor-Krivov merged commit 6000ece into main Oct 24, 2025
24 of 27 checks passed
@Egor-Krivov Egor-Krivov deleted the egor/sglang_test branch October 24, 2025 12:17
Egor-Krivov added a commit that referenced this pull request Oct 27, 2025
@Egor-Krivov
[Liger-Kernels] Fix Liger-Kernels tests hanging (#5382)
2fadfe7 
Resolves
#5292

There's also refactoring of Liger-Kernels installation to be consistent
with sglang, vllm

PR depends on:
- [x] #5376

Before merging:
- [x] Merge
#5376
- [x] Test third-party testing CI, there should be no hanging for liger
kernels
- [x] Test third-party benchmarks CI
Egor-Krivov added a commit that referenced this pull request Oct 31, 2025
@Egor-Krivov
[CI][sglang] Add benchmark from sglang (#5341)
37bc4ad 
This is one of the key workloads provided by sglang team, I locally
optimized code with tensor descriptor as an example for them.

- [x] Depends on
#5376
- [x] Let's merge
#5382 first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anmyachev anmyachev anmyachev approved these changes

@whitneywhtsang whitneywhtsang whitneywhtsang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI][sglang] Our sglang build is broken

4 participants

@Egor-Krivov @anmyachev @whitneywhtsang