Merge OpenAI Triton commit e4e68d1
#5597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow on to: triton-lang/triton#8137. This PR coupled with the Triton pass pipeline override adds the ability to call out of tree TTIR and TTGIR MLIR passes. Integration has been done with both the Python and triton-opt interfaces. Co-authored w/ @plotfi --------- Co-authored-by: Puyan Lotfi <[email protected]>
This PR supports - the `CDNA4MXScaleLayout.unswizzle_data` method used in GPT-OSS model - padding tensors with 0 when doing scale preshuffling
For some num_warps, num_stages and tile_size, BlockPingpong will exit early without leaving a message. Added message for these cases so people can be aware that pingpong wasn't really involved. Also add some transparency for debugging. This shouldn't change the way how BlockPingong or anything else in Triton is used. <!--- The core Triton is a small number of people, and we receive many PRs (thank you!). To help us review your code more quickly, **if you are a new contributor (less than 3 PRs merged) we ask that you complete the following tasks and include the filled-out checklist in your PR description.** Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> # New contributor declaration - [X] I am not making a trivial change, such as fixing a typo in a comment. - [X] I have written a PR description following these [rules](https://cbea.ms/git-commit/#why-not-how). - [X] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`. - Select one of the following. - [ ] I have added tests. - `/test` for `lit` tests - `/unittest` for C++ tests - `/python/test` for end-to-end tests - [X] This PR does not need a test because `Just added a few message to make sure BlockPingpong won't silently exit early, making it easier to debug`. - Select one of the following. - [X] I have not added any `lit` tests. - [ ] The `lit` tests I have added follow these [best practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices), including the "tests should be minimal" section. (Usually running Python code and using the instructions it generates is not minimal.) Co-authored-by: Peiying Hua <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
Signed-off-by: Anatoly Myachev <[email protected]>
whitneywhtsang
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Triton base from acd8104 to e4e68d1 (Nov 23).
Pass rate: 95.42%
Test on Windows: https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/19860164189/job/56907925826